diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't trigger deprecation for deprecated aliases pointing to deprecated definitions

Browse Source
This commit is contained in:
Robin Chalas 2021-01-13 16:24:24 +01:00
parent d23b74ebce
commit 38f98a1165
2 changed files with 42 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/DependencyInjection/Compiler/ResolveReferencesToAliasesPass.php
View File

@ -62,7 +62,10 @@ class ResolveReferencesToAliasesPass extends AbstractRecursivePass
$alias = $container->getAlias($id);
if ($alias->isDeprecated()) {
@trigger_error(sprintf('%s. It is being referenced by the "%s" %s.', rtrim($alias->getDeprecationMessage($id), '. '), $this->currentId, $container->hasDefinition($this->currentId) ? 'service' : 'alias'), \E_USER_DEPRECATED);
$referencingDefinition = $container->hasDefinition($this->currentId) ? $container->getDefinition($this->currentId) : $container->getAlias($this->currentId);
if (!$referencingDefinition->isDeprecated()) {
@trigger_error(sprintf('%s. It is being referenced by the "%s" %s.', rtrim($alias->getDeprecationMessage($id), '. '), $this->currentId, $container->hasDefinition($this->currentId) ? 'service' : 'alias'), \E_USER_DEPRECATED);
}
}
$seen = [];

38
src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveReferencesToAliasesPassTest.php
View File

@ -123,6 +123,44 @@ class ResolveReferencesToAliasesPassTest extends TestCase
$this->process($container);
}
public function testNoDeprecationNoticeWhenReferencedByDeprecatedAlias()
{
$container = new ContainerBuilder();
$container->register('foo', 'stdClass');
$aliasDeprecated = new Alias('foo');
$aliasDeprecated->setDeprecated(true);
$container->setAlias('deprecated_foo_alias', $aliasDeprecated);
$alias = new Alias('deprecated_foo_alias');
$alias->setDeprecated(true);
$container->setAlias('alias', $alias);
$this->process($container);
$this->addToAssertionCount(1);
}
public function testNoDeprecationNoticeWhenReferencedByDeprecatedDefinition()
{
$container = new ContainerBuilder();
$container->register('foo', 'stdClass');
$aliasDeprecated = new Alias('foo');
$aliasDeprecated->setDeprecated(true);
$container->setAlias('foo_aliased', $aliasDeprecated);
$container
->register('definition')
->setDeprecated(true)
->setArguments([new Reference('foo_aliased')])
;
$this->process($container);
$this->addToAssertionCount(1);
}
protected function process(ContainerBuilder $container)
{
$pass = new ResolveReferencesToAliasesPass();