diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Security][Acl] Reduce query size when Select ACL entries for many instances of the same Type at once

Browse Source
This commit is contained in:
Ilya Biryukov 2012-12-25 22:46:10 +00:00 committed by Joseph Bielawski
parent dc4a10e931
commit 3c3a90b9e5
1 changed files with 40 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/Symfony/Component/Security/Acl/Dbal/AclProvider.php
View File

@ -258,6 +258,32 @@ SELECTCLAUSE;
WHERE (
SELECTCLAUSE;
$types = array();
for ($i=0,$c=count($batch); $i<$c; $i++) {
if(!isset($types[$batch[$i]->getType()])) {
$types[$batch[$i]->getType()] = true;
if(count($batch) > 1) {
break;
}
}
}
if(count($types) === 1) {
$where = '(o.object_identifier IN (%s) AND c.class_type = %s)';
$ids = array();
for ($i=0,$c=count($batch); $i<$c; $i++) {
$ids[] = $this->connection->quote($batch[$i]->getIdentifier());
}
$sql .= sprintf(
$where,
implode(',', $ids),
$this->connection->quote($batch[0]->getType())
);
} else {
$where = '(o.object_identifier = %s AND c.class_type = %s)';
for ($i=0,$c=count($batch); $i<$c; $i++) {
$sql .= sprintf(
@ -270,6 +296,8 @@ SELECTCLAUSE;
$sql .= ' OR ';
}
}
}
$sql .= ')';