diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #41948 [PhpUnitBridge] Avoid triggering the autoloader in Deprecation::isLegacy() (derrabus) 

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Avoid triggering the autoloader in Deprecation::isLegacy()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

The low-deps tests are currently failing because Deprecation::isLegacy() keeps triggering the autoloader and might even do so while `DebugClassLoader` considers a failed autoload attempt as an error.

Commits
-------

b95dfede5f Avoid triggering the autoloader in Deprecation::isLegacy()
This commit is contained in:
Nicolas Grekas 2021-07-02 18:03:29 +02:00
parent cf0f3c9834 b95dfede5f
commit 3c72d518f5
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
View File

@ -20,6 +20,8 @@ use Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerFor;
use Symfony\Component\Debug\DebugClassLoader as LegacyDebugClassLoader;
use Symfony\Component\ErrorHandler\DebugClassLoader;
class_exists(Groups::class);
/**
* @internal
*/
@ -194,7 +196,7 @@ class Deprecation
}
$method = $this->originatingMethod();
$groups = class_exists(Groups::class) ? [new Groups(), 'groups'] : [Test::class, 'getGroups'];
$groups = class_exists(Groups::class, false) ? [new Groups(), 'groups'] : [Test::class, 'getGroups'];
return 0 === strpos($method, 'testLegacy')
|| 0 === strpos($method, 'provideLegacy')