bug #11695 [Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise (webmozart)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11695).
Discussion
----------
[Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
I just ran the tests with ICU 52.1 installed and noticed that a few of them failed. This PR fixes these tests.
Commits
-------
5440ed5
[Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise
This commit is contained in:
commit
3d59e3417f
@ -82,7 +82,7 @@ class CountryValidatorTest extends AbstractConstraintValidatorTest
|
|||||||
$this->validator->validate($country, $constraint);
|
$this->validator->validate($country, $constraint);
|
||||||
|
|
||||||
$this->assertViolation('myMessage', array(
|
$this->assertViolation('myMessage', array(
|
||||||
'{{ value }}' => $country,
|
'{{ value }}' => '"'.$country.'"',
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -96,7 +96,7 @@ class CurrencyValidatorTest extends AbstractConstraintValidatorTest
|
|||||||
$this->validator->validate($currency, $constraint);
|
$this->validator->validate($currency, $constraint);
|
||||||
|
|
||||||
$this->assertViolation('myMessage', array(
|
$this->assertViolation('myMessage', array(
|
||||||
'{{ value }}' => $currency,
|
'{{ value }}' => '"'.$currency.'"',
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -14,7 +14,6 @@ namespace Symfony\Component\Validator\Tests\Constraints;
|
|||||||
use Symfony\Component\Intl\Util\IntlTestHelper;
|
use Symfony\Component\Intl\Util\IntlTestHelper;
|
||||||
use Symfony\Component\Validator\Constraints\Language;
|
use Symfony\Component\Validator\Constraints\Language;
|
||||||
use Symfony\Component\Validator\Constraints\LanguageValidator;
|
use Symfony\Component\Validator\Constraints\LanguageValidator;
|
||||||
use Symfony\Component\Validator\Validation;
|
|
||||||
|
|
||||||
class LanguageValidatorTest extends AbstractConstraintValidatorTest
|
class LanguageValidatorTest extends AbstractConstraintValidatorTest
|
||||||
{
|
{
|
||||||
@ -83,7 +82,7 @@ class LanguageValidatorTest extends AbstractConstraintValidatorTest
|
|||||||
$this->validator->validate($language, $constraint);
|
$this->validator->validate($language, $constraint);
|
||||||
|
|
||||||
$this->assertViolation('myMessage', array(
|
$this->assertViolation('myMessage', array(
|
||||||
'{{ value }}' => $language,
|
'{{ value }}' => '"'.$language.'"',
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -14,7 +14,6 @@ namespace Symfony\Component\Validator\Tests\Constraints;
|
|||||||
use Symfony\Component\Intl\Util\IntlTestHelper;
|
use Symfony\Component\Intl\Util\IntlTestHelper;
|
||||||
use Symfony\Component\Validator\Constraints\Locale;
|
use Symfony\Component\Validator\Constraints\Locale;
|
||||||
use Symfony\Component\Validator\Constraints\LocaleValidator;
|
use Symfony\Component\Validator\Constraints\LocaleValidator;
|
||||||
use Symfony\Component\Validator\Validation;
|
|
||||||
|
|
||||||
class LocaleValidatorTest extends AbstractConstraintValidatorTest
|
class LocaleValidatorTest extends AbstractConstraintValidatorTest
|
||||||
{
|
{
|
||||||
@ -85,7 +84,7 @@ class LocaleValidatorTest extends AbstractConstraintValidatorTest
|
|||||||
$this->validator->validate($locale, $constraint);
|
$this->validator->validate($locale, $constraint);
|
||||||
|
|
||||||
$this->assertViolation('myMessage', array(
|
$this->assertViolation('myMessage', array(
|
||||||
'{{ value }}' => $locale,
|
'{{ value }}' => '"'.$locale.'"',
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user