From c794fa821b2d8b9712f30a5c81684b9022f53c85 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 28 Feb 2018 10:29:53 +0100 Subject: [PATCH 1/3] [Routing] fix typo --- .../Routing/Tests/Matcher/RedirectableUrlMatcherTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php b/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php index fc7683903f..5c0156192b 100644 --- a/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php +++ b/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php @@ -56,7 +56,7 @@ class RedirectableUrlMatcherTest extends UrlMatcherTest $matcher->match('/foo'); } - public function testNoSchemaRedirectIfOnOfMultipleSchemesMatches() + public function testNoSchemaRedirectIfOneOfMultipleSchemesMatches() { $coll = new RouteCollection(); $coll->add('foo', new Route('/foo', array(), array(), array(), '', array('https', 'http'))); From 2f4b867b509b6cd0a2e533baf5726ab1d5b63ba3 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 28 Feb 2018 10:35:21 +0100 Subject: [PATCH 2/3] [Routing] remove dead code --- .../Routing/Tests/Matcher/DumpedRedirectableUrlMatcherTest.php | 2 +- .../Component/Routing/Tests/Matcher/DumpedUrlMatcherTest.php | 2 +- .../Routing/Tests/Matcher/RedirectableUrlMatcherTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Routing/Tests/Matcher/DumpedRedirectableUrlMatcherTest.php b/src/Symfony/Component/Routing/Tests/Matcher/DumpedRedirectableUrlMatcherTest.php index 28f65aeeb5..cfbb524d3a 100644 --- a/src/Symfony/Component/Routing/Tests/Matcher/DumpedRedirectableUrlMatcherTest.php +++ b/src/Symfony/Component/Routing/Tests/Matcher/DumpedRedirectableUrlMatcherTest.php @@ -25,7 +25,7 @@ class DumpedRedirectableUrlMatcherTest extends RedirectableUrlMatcherTest $class = 'DumpedRedirectableUrlMatcher'.++$i; $dumper = new PhpMatcherDumper($routes); - $dumpedRoutes = eval('?>'.$dumper->dump(array('class' => $class, 'base_class' => 'Symfony\Component\Routing\Tests\Matcher\TestDumpedRedirectableUrlMatcher'))); + eval('?>'.$dumper->dump(array('class' => $class, 'base_class' => 'Symfony\Component\Routing\Tests\Matcher\TestDumpedRedirectableUrlMatcher'))); return $this->getMockBuilder($class) ->setConstructorArgs(array($context ?: new RequestContext())) diff --git a/src/Symfony/Component/Routing/Tests/Matcher/DumpedUrlMatcherTest.php b/src/Symfony/Component/Routing/Tests/Matcher/DumpedUrlMatcherTest.php index e36a0220d9..880b2b13b1 100644 --- a/src/Symfony/Component/Routing/Tests/Matcher/DumpedUrlMatcherTest.php +++ b/src/Symfony/Component/Routing/Tests/Matcher/DumpedUrlMatcherTest.php @@ -41,7 +41,7 @@ class DumpedUrlMatcherTest extends UrlMatcherTest $class = 'DumpedUrlMatcher'.++$i; $dumper = new PhpMatcherDumper($routes); - $dumpedRoutes = eval('?>'.$dumper->dump(array('class' => $class))); + eval('?>'.$dumper->dump(array('class' => $class))); return new $class($context ?: new RequestContext()); } diff --git a/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php b/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php index 5c0156192b..e5d189d662 100644 --- a/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php +++ b/src/Symfony/Component/Routing/Tests/Matcher/RedirectableUrlMatcherTest.php @@ -17,7 +17,7 @@ use Symfony\Component\Routing\RequestContext; class RedirectableUrlMatcherTest extends UrlMatcherTest { - public function testRedirectWhenNoSlash() + public function testMissingTrailingSlash() { $coll = new RouteCollection(); $coll->add('foo', new Route('/foo/')); From b1b6093f3d97699b2adcf1a1e58e528eb26805a1 Mon Sep 17 00:00:00 2001 From: Philipp Keck Date: Tue, 27 Feb 2018 22:51:18 +0100 Subject: [PATCH 3/3] Pass on previous exception in FatalThrowableError --- src/Symfony/Component/Debug/Exception/FatalThrowableError.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Debug/Exception/FatalThrowableError.php b/src/Symfony/Component/Debug/Exception/FatalThrowableError.php index 34f43b17b1..fafc92263e 100644 --- a/src/Symfony/Component/Debug/Exception/FatalThrowableError.php +++ b/src/Symfony/Component/Debug/Exception/FatalThrowableError.php @@ -36,7 +36,8 @@ class FatalThrowableError extends FatalErrorException $e->getCode(), $severity, $e->getFile(), - $e->getLine() + $e->getLine(), + $e->getPrevious() ); $this->setTrace($e->getTrace());