merged branch vicb/memcache/fix (PR #3363)

Commits
-------

b95284e [Profiler] Fix memcache(d)

Discussion
----------

[Profiler] Fix memcache(d) storages

This fixes an ambiguity...

The memcache(d) storages have a `$lifetime` option. The name indicates that we are talking about a ttl (in seconds). This is wrong is `$lifetime` > 2592000 (=30 days), see http://fr.php.net/manual/en/memcache.set.php.

Doctrine is also [affected](e9ab2d2cca).

The ambiguity also exists in the session storage but to a lesser extend as those storage directly use memcache(d) options rather than a `$lifetime`. @drak could you confirm ?

Hopefully the Cache Component will get it right (#3211).

src/Symfony/Component/HttpKernel/Profiler/BaseMemcacheProfilerStorage.php

@@ -29,7 +29,7 @@ abstract class BaseMemcacheProfilerStorage implements ProfilerStorageInterface
      * @param string $dsn      A data source name
      * @param string $username
      * @param string $password
-     * @param int $lifetime    The lifetime to use for the purge
+     * @param int    $lifetime The lifetime to use for the purge
      */
     public function __construct($dsn, $username = '', $password = '', $lifetime = 86400)
     {

src/Symfony/Component/HttpKernel/Profiler/MemcacheProfilerStorage.php

@@ -63,7 +63,7 @@ class MemcacheProfilerStorage extends BaseMemcacheProfilerStorage
      */
     protected function setValue($key, $value, $expiration = 0)
     {
-        return $this->getMemcache()->set($key, $value, false, $expiration);
+        return $this->getMemcache()->set($key, $value, false, time() + $expiration);
     }
 
     /**

src/Symfony/Component/HttpKernel/Profiler/MemcachedProfilerStorage.php

@@ -67,7 +67,7 @@ class MemcachedProfilerStorage extends BaseMemcacheProfilerStorage
      */
     protected function setValue($key, $value, $expiration = 0)
     {
-        return $this->getMemcached()->set($key, $value, $expiration);
+        return $this->getMemcached()->set($key, $value, false, time() + $expiration);
     }
 
     /**