Merge branch '3.3' into 3.4

* 3.3:
  CS: recover no_break_comment
  [DI] Fix non-instantiables auto-discovery
This commit is contained in:
Fabien Potencier 2017-09-15 10:11:35 -07:00
commit 40a3466268
7 changed files with 13 additions and 4 deletions

View File

@ -9,7 +9,6 @@ return PhpCsFixer\Config::create()
'@Symfony' => true,
'@Symfony:risky' => true,
'array_syntax' => array('syntax' => 'long'),
'no_break_comment' => false,
'protected_to_private' => false,
))
->setRiskyAllowed(true)

View File

@ -133,7 +133,7 @@ abstract class FileLoader extends BaseFileLoader
throw new InvalidArgumentException(sprintf('Expected to find class "%s" in file "%s" while importing services from resource "%s", but it was not found! Check the namespace prefix used with the resource.', $class, $path, $pattern));
}
if (!$r->isInterface() && !$r->isTrait() && !$r->isAbstract()) {
if ($r->isInstantiable()) {
$classes[] = $class;
}
}

View File

@ -62,8 +62,11 @@ class ServerParams
switch (substr($iniMax, -1)) {
case 't': $max *= 1024;
// no break
case 'g': $max *= 1024;
// no break
case 'm': $max *= 1024;
// no break
case 'k': $max *= 1024;
}

View File

@ -259,8 +259,11 @@ class UploadedFile extends File
switch (substr($iniMax, -1)) {
case 't': $max *= 1024;
// no break
case 'g': $max *= 1024;
// no break
case 'm': $max *= 1024;
// no break
case 'k': $max *= 1024;
}

View File

@ -99,8 +99,11 @@ class MemoryDataCollector extends DataCollector implements LateDataCollectorInte
switch (substr($memoryLimit, -1)) {
case 't': $max *= 1024;
// no break
case 'g': $max *= 1024;
// no break
case 'm': $max *= 1024;
// no break
case 'k': $max *= 1024;
}

View File

@ -349,7 +349,7 @@ class Data implements \ArrayAccess, \Countable, \IteratorAggregate
$item = clone $item;
$item->type = $item->class;
$item->class = $item->value;
// No break;
// no break
case Stub::TYPE_OBJECT:
case Stub::TYPE_RESOURCE:
$withChildren = $children && $cursor->depth !== $this->maxDepth && $this->maxItemsPerDepth;

View File

@ -336,6 +336,7 @@ class CliDumper extends AbstractDumper
break;
}
$style = 'index';
// no break
case Cursor::HASH_ASSOC:
if (is_int($key)) {
$this->line .= $this->style($style, $key).' => ';
@ -346,7 +347,7 @@ class CliDumper extends AbstractDumper
case Cursor::HASH_RESOURCE:
$key = "\0~\0".$key;
// No break;
// no break
case Cursor::HASH_OBJECT:
if (!isset($key[0]) || "\0" !== $key[0]) {
$this->line .= '+'.$bin.$this->style('public', $key).': ';