diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #35872 Optimize HttpClient when body is iterable (jderusse)

Browse Source 
This PR was merged into the 5.1-dev branch.

Discussion
----------

Optimize HttpClient when body is iterable

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

Small optimization on HttpClient by avoiding calling Reflection when body is a known Traversable.

Commits
-------

03b7743ff5 Optimize HttpClient when body is iterable
This commit is contained in:
Nicolas Grekas 2020-02-27 11:09:40 +01:00
commit 421c7f8fcd
1 changed files with 26 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/Symfony/Component/HttpClient/HttpClientTrait.php
View File

@ -271,8 +271,31 @@ trait HttpClientTrait
return http_build_query($body, '', '&', PHP_QUERY_RFC1738);
}
if (\is_string($body)) {
return $body;
}
$generatorToCallable = static function (\Generator $body): \Closure {
return static function () use ($body) {
while ($body->valid()) {
$chunk = $body->current();
$body->next();
if ('' !== $chunk) {
return $chunk;
}
}
return '';
};
};
if ($body instanceof \Generator) {
return $generatorToCallable($body);
}
if ($body instanceof \Traversable) {
$body = function () use ($body) { yield from $body; };
return $generatorToCallable((static function ($body) { yield from $body; })($body));
}
if ($body instanceof \Closure) {
@ -281,24 +304,14 @@ trait HttpClientTrait
if ($r->isGenerator()) {
$body = $body(self::$CHUNK_SIZE);
$body = function () use ($body) {
while ($body->valid()) {
$chunk = $body->current();
$body->next();
if ('' !== $chunk) {
return $chunk;
}
}
return '';
};
return $generatorToCallable($body);
}
return $body;
}
if (!\is_string($body) && !\is_array(@stream_get_meta_data($body))) {
if (!\is_array(@stream_get_meta_data($body))) {
throw new InvalidArgumentException(sprintf('Option "body" must be string, stream resource, iterable or callable, %s given.', \is_resource($body) ? get_resource_type($body) : \gettype($body)));
}