From b40801a492cc5516ff0143b3e6978b1935326f24 Mon Sep 17 00:00:00 2001 From: Emanuele Iannone Date: Sun, 23 Dec 2018 15:44:15 +0100 Subject: [PATCH] Fix erasing cookies issue Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option. See issue https://github.com/symfony/symfony/issues/29675 --- .../HttpFoundation/Session/Storage/NativeSessionStorage.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php index 156a0d4555..232eb64cfd 100644 --- a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php +++ b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php @@ -153,7 +153,7 @@ class NativeSessionStorage implements SessionStorageInterface if (null !== $this->emulateSameSite) { $originalCookie = SessionUtils::popSessionCookie(session_name(), session_id()); if (null !== $originalCookie) { - header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite)); + header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite), false); } } @@ -225,7 +225,7 @@ class NativeSessionStorage implements SessionStorageInterface if (null !== $this->emulateSameSite) { $originalCookie = SessionUtils::popSessionCookie(session_name(), session_id()); if (null !== $originalCookie) { - header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite)); + header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite), false); } }