diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #12216 [FrameworkBundle] [DX] Displays friendly message if the event does not have any registered listeners (matthieuauger)

Browse Source 
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #12216).

Discussion
----------

[FrameworkBundle] [DX] Displays friendly message if the event does not have any registered listeners

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Currently if you run debug:event-dispatcher on an event without registered listeners, the output looks like this

![capture d ecran de 2014-10-13 00 43 26](https://cloud.githubusercontent.com/assets/1172099/4607814/486213e4-5261-11e4-93b3-6ef009c19a05.png)

This PR just add a friendly message like debug:container or debug:router :

![capture d ecran de 2014-10-13 00 44 38](https://cloud.githubusercontent.com/assets/1172099/4607819/7a28a01e-5261-11e4-9b07-d0ca36725da2.png)

Commits
-------

a5628bd Displays friendly message if the event does not have any registered listeners
This commit is contained in:
Fabien Potencier 2015-03-26 13:59:20 +01:00
commit 433f640247
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Symfony/Bundle/FrameworkBundle/Command/EventDispatcherDebugCommand.php
View File

@ -58,14 +58,28 @@ EOF
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
$dispatcher = $this->getEventDispatcher();
if ($event = $input->getArgument('event')) {
if (!$dispatcher->hasListeners($event)) {
$formatter = $this->getHelperSet()->get('formatter');
$formattedBlock = $formatter->formatBlock(
sprintf('[NOTE] The event "%s" does not have any registered listeners.', $event),
'fg=yellow',
true
);
$output->writeln($formattedBlock);
return;
}
$options = array('event' => $event);
} else {
$options = array();
}
$dispatcher = $this->getEventDispatcher();
$helper = new DescriptorHelper();
$options['format'] = $input->getOption('format');
$options['raw_text'] = $input->getOption('raw');