From 450d33ff3b2d6a8488c09e97688baefecb51fd62 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Mon, 12 Jul 2021 12:42:37 +0200 Subject: [PATCH] [Cache] clarify RedisStore::evaluate() --- src/Symfony/Component/Lock/Store/RedisStore.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/Symfony/Component/Lock/Store/RedisStore.php b/src/Symfony/Component/Lock/Store/RedisStore.php index be59fc7abc..0060f12a6b 100644 --- a/src/Symfony/Component/Lock/Store/RedisStore.php +++ b/src/Symfony/Component/Lock/Store/RedisStore.php @@ -281,19 +281,15 @@ class RedisStore implements SharedLockStoreInterface } return $result; - - return $this->redis->_instance($this->redis->_target($resource))->eval($script, array_merge([$resource], $args), 1); } - if ($this->redis instanceof \Predis\ClientInterface) { - try { - return $this->redis->eval(...array_merge([$script, 1, $resource], $args)); - } catch (ServerException $e) { - throw new LockStorageException($e->getMessage(), $e->getCode(), $e); - } - } + \assert($this->redis instanceof \Predis\ClientInterface); - throw new InvalidArgumentException(sprintf('"%s()" expects being initialized with a Redis, RedisArray, RedisCluster or Predis\ClientInterface, "%s" given.', __METHOD__, get_debug_type($this->redis))); + try { + return $this->redis->eval(...array_merge([$script, 1, $resource], $args)); + } catch (ServerException $e) { + throw new LockStorageException($e->getMessage(), $e->getCode(), $e); + } } private function getUniqueToken(Key $key): string