minor #16147 [VarDumper] consistent signature of getDump() in class + trait (xabbuh)
This PR was merged into the 2.8 branch.
Discussion
----------
[VarDumper] consistent signature of getDump() in class + trait
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16126
| License | MIT
| Doc PR |
Commits
-------
48a9e83
consistent signature of getDump() in class + trait
This commit is contained in:
commit
45a5b005d5
@ -29,7 +29,7 @@ abstract class VarDumperTestCase extends \PHPUnit_Framework_TestCase
|
|||||||
$this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
|
$this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
|
||||||
}
|
}
|
||||||
|
|
||||||
private function getDump($data)
|
protected function getDump($data)
|
||||||
{
|
{
|
||||||
$h = fopen('php://memory', 'r+b');
|
$h = fopen('php://memory', 'r+b');
|
||||||
$cloner = new VarCloner();
|
$cloner = new VarCloner();
|
||||||
|
@ -29,7 +29,7 @@ trait VarDumperTestTrait
|
|||||||
$this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
|
$this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function getDump($data)
|
protected function getDump($data)
|
||||||
{
|
{
|
||||||
$h = fopen('php://memory', 'r+b');
|
$h = fopen('php://memory', 'r+b');
|
||||||
$cloner = new VarCloner();
|
$cloner = new VarCloner();
|
||||||
|
Reference in New Issue
Block a user