SCA: dropped unused mocks, duplicate import and a function alias usage
This commit is contained in:
parent
6af3c6bb01
commit
484668fe56
@ -14,7 +14,6 @@ namespace Symfony\Component\Config\Tests\Definition\Builder;
|
|||||||
use PHPUnit\Framework\TestCase;
|
use PHPUnit\Framework\TestCase;
|
||||||
use Symfony\Component\Config\Definition\Builder\FloatNodeDefinition;
|
use Symfony\Component\Config\Definition\Builder\FloatNodeDefinition;
|
||||||
use Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition;
|
use Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition;
|
||||||
use Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition as NumericNodeDefinition;
|
|
||||||
|
|
||||||
class NumericNodeDefinitionTest extends TestCase
|
class NumericNodeDefinitionTest extends TestCase
|
||||||
{
|
{
|
||||||
@ -22,7 +21,7 @@ class NumericNodeDefinitionTest extends TestCase
|
|||||||
{
|
{
|
||||||
$this->expectException('InvalidArgumentException');
|
$this->expectException('InvalidArgumentException');
|
||||||
$this->expectExceptionMessage('You cannot define a min(4) as you already have a max(3)');
|
$this->expectExceptionMessage('You cannot define a min(4) as you already have a max(3)');
|
||||||
$def = new NumericNodeDefinition('foo');
|
$def = new IntegerNodeDefinition('foo');
|
||||||
$def->max(3)->min(4);
|
$def->max(3)->min(4);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -30,7 +29,7 @@ class NumericNodeDefinitionTest extends TestCase
|
|||||||
{
|
{
|
||||||
$this->expectException('InvalidArgumentException');
|
$this->expectException('InvalidArgumentException');
|
||||||
$this->expectExceptionMessage('You cannot define a max(2) as you already have a min(3)');
|
$this->expectExceptionMessage('You cannot define a max(2) as you already have a min(3)');
|
||||||
$node = new NumericNodeDefinition('foo');
|
$node = new IntegerNodeDefinition('foo');
|
||||||
$node->min(3)->max(2);
|
$node->min(3)->max(2);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -84,7 +83,7 @@ class NumericNodeDefinitionTest extends TestCase
|
|||||||
{
|
{
|
||||||
$this->expectException('Symfony\Component\Config\Definition\Exception\InvalidDefinitionException');
|
$this->expectException('Symfony\Component\Config\Definition\Exception\InvalidDefinitionException');
|
||||||
$this->expectExceptionMessage('->cannotBeEmpty() is not applicable to NumericNodeDefinition.');
|
$this->expectExceptionMessage('->cannotBeEmpty() is not applicable to NumericNodeDefinition.');
|
||||||
$def = new NumericNodeDefinition('foo');
|
$def = new IntegerNodeDefinition('foo');
|
||||||
$def->cannotBeEmpty();
|
$def->cannotBeEmpty();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -70,7 +70,6 @@ class ExpressionLanguageTest extends TestCase
|
|||||||
{
|
{
|
||||||
$cacheMock = $this->getMockBuilder('Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface')->getMock();
|
$cacheMock = $this->getMockBuilder('Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface')->getMock();
|
||||||
|
|
||||||
$cacheItemMock = $this->getMockBuilder('Psr\Cache\CacheItemInterface')->getMock();
|
|
||||||
$savedParsedExpression = null;
|
$savedParsedExpression = null;
|
||||||
$expressionLanguage = new ExpressionLanguage($cacheMock);
|
$expressionLanguage = new ExpressionLanguage($cacheMock);
|
||||||
|
|
||||||
|
@ -14,7 +14,7 @@ class LdapTestCase extends TestCase
|
|||||||
$this->markTestSkipped('No server is listening on LDAP_HOST:LDAP_PORT');
|
$this->markTestSkipped('No server is listening on LDAP_HOST:LDAP_PORT');
|
||||||
}
|
}
|
||||||
|
|
||||||
ldap_close($h);
|
ldap_unbind($h);
|
||||||
|
|
||||||
return [
|
return [
|
||||||
'host' => getenv('LDAP_HOST'),
|
'host' => getenv('LDAP_HOST'),
|
||||||
|
@ -85,13 +85,6 @@ class GuardAuthenticatorHandlerTest extends TestCase
|
|||||||
*/
|
*/
|
||||||
public function testHandleAuthenticationClearsToken($tokenClass, $tokenProviderKey, $actualProviderKey)
|
public function testHandleAuthenticationClearsToken($tokenClass, $tokenProviderKey, $actualProviderKey)
|
||||||
{
|
{
|
||||||
$token = $this->getMockBuilder($tokenClass)
|
|
||||||
->disableOriginalConstructor()
|
|
||||||
->getMock();
|
|
||||||
$token->expects($this->any())
|
|
||||||
->method('getProviderKey')
|
|
||||||
->willReturn($tokenProviderKey);
|
|
||||||
|
|
||||||
$this->tokenStorage->expects($this->never())
|
$this->tokenStorage->expects($this->never())
|
||||||
->method('setToken')
|
->method('setToken')
|
||||||
->with(null);
|
->with(null);
|
||||||
|
@ -74,8 +74,6 @@ class BasicAuthenticationListenerTest extends TestCase
|
|||||||
'PHP_AUTH_PW' => 'ThePassword',
|
'PHP_AUTH_PW' => 'ThePassword',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock();
|
|
||||||
|
|
||||||
$tokenStorage = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface')->getMock();
|
$tokenStorage = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface')->getMock();
|
||||||
$tokenStorage
|
$tokenStorage
|
||||||
->expects($this->any())
|
->expects($this->any())
|
||||||
|
@ -124,7 +124,6 @@ class AbstractRememberMeServicesTest extends TestCase
|
|||||||
$service = $this->getService(null, ['name' => 'foo', 'always_remember_me' => true, 'path' => null, 'domain' => null]);
|
$service = $this->getService(null, ['name' => 'foo', 'always_remember_me' => true, 'path' => null, 'domain' => null]);
|
||||||
$request = new Request();
|
$request = new Request();
|
||||||
$response = new Response();
|
$response = new Response();
|
||||||
$account = $this->getMockBuilder('Symfony\Component\Security\Core\User\UserInterface')->getMock();
|
|
||||||
$token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock();
|
$token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock();
|
||||||
$token
|
$token
|
||||||
->expects($this->once())
|
->expects($this->once())
|
||||||
|
@ -50,14 +50,11 @@ class TranslationExtractorPassTest extends TestCase
|
|||||||
{
|
{
|
||||||
$this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException');
|
$this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException');
|
||||||
$this->expectExceptionMessage('The alias for the tag "translation.extractor" of service "foo.id" must be set.');
|
$this->expectExceptionMessage('The alias for the tag "translation.extractor" of service "foo.id" must be set.');
|
||||||
$definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->disableOriginalConstructor()->getMock();
|
|
||||||
$container = new ContainerBuilder();
|
$container = new ContainerBuilder();
|
||||||
$container->register('translation.extractor');
|
$container->register('translation.extractor');
|
||||||
$container->register('foo.id')
|
$container->register('foo.id')
|
||||||
->addTag('translation.extractor', []);
|
->addTag('translation.extractor', []);
|
||||||
|
|
||||||
$definition->expects($this->never())->method('addMethodCall');
|
|
||||||
|
|
||||||
$translationDumperPass = new TranslationExtractorPass();
|
$translationDumperPass = new TranslationExtractorPass();
|
||||||
$translationDumperPass->process($container);
|
$translationDumperPass->process($container);
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user