diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #20409 [SecurityBundle] Make the FirewallConfig class final (ogizanagi)

Browse Source 
This PR was merged into the 3.2-dev branch.

Discussion
----------

[SecurityBundle] Make the FirewallConfig class final

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

I suggest to make the `FirewallConfig` class final. This value object is only built by the `SecurityExtension` from the `SecurityBundle` and is not meant to be an extension point.

ping @chalasr

Commits
-------

5963627 [SecurityBundle] Make the FirewallConfig class final
This commit is contained in:
Fabien Potencier 2016-11-04 07:00:04 -07:00
commit 48ff2bd8a8
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php
View File

@ -14,7 +14,7 @@ namespace Symfony\Bundle\SecurityBundle\Security;
/** /**
* @author Robin Chalas <robin.chalas@gmail.com> * @author Robin Chalas <robin.chalas@gmail.com>
*/ */
class FirewallConfig final class FirewallConfig
{ {
private $name; private $name;
private $requestMatcher; private $requestMatcher;

5
src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallContextTest.php
View File

@ -20,10 +20,7 @@ class FirewallContextTest extends \PHPUnit_Framework_TestCase
{ {
public function testGetters() public function testGetters()
{ {
$config = $this $config = new FirewallConfig('main', 'request_matcher');
->getMockBuilder(FirewallConfig::class)
->disableOriginalConstructor()
->getMock();
$exceptionListener = $this $exceptionListener = $this
->getMockBuilder(ExceptionListener::class) ->getMockBuilder(ExceptionListener::class)