diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feature #18867 [Cache] Drop counting hit/miss in ProxyAdapter (nicolas-grekas) 

This PR was merged into the 3.1 branch.

Discussion
----------

[Cache] Drop counting hit/miss in ProxyAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We have no use case for these methods yet. Let's drop them and save some BC constraints.

Commits
-------

9461750 [Cache] Drop counting hit/miss in ProxyAdapter
This commit is contained in:
Fabien Potencier 2016-05-25 17:27:34 +02:00
parent 7dc1491ec0 9461750bd0
commit 4974a8b5f5
2 changed files with 2 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/Symfony/Component/Cache/Adapter/ProxyAdapter.php
View File

@ -24,8 +24,6 @@ class ProxyAdapter implements AdapterInterface
private $namespace;
private $namespaceLen;
private $createCacheItem;
private $hits = 0;
private $misses = 0;
public function __construct(CacheItemPoolInterface $pool, $namespace = '', $defaultLifetime = 0)
{
@ -54,13 +52,8 @@ class ProxyAdapter implements AdapterInterface
{
$f = $this->createCacheItem;
$item = $this->pool->getItem($this->getId($key));
if ($isHit = $item->isHit()) {
++$this->hits;
} else {
++$this->misses;
}
return $f($key, $item->get(), $isHit);
return $f($key, $item->get(), $item->isHit());
}
/**
@ -158,39 +151,14 @@ class ProxyAdapter implements AdapterInterface
$f = $this->createCacheItem;
foreach ($items as $key => $item) {
if ($isHit = $item->isHit()) {
++$this->hits;
} else {
++$this->misses;
}
if ($this->namespaceLen) {
$key = substr($key, $this->namespaceLen);
}
yield $key => $f($key, $item->get(), $isHit);
yield $key => $f($key, $item->get(), $item->isHit());
}
}
/**
* Returns the number of cache read hits.
*
* @return int
*/
public function getHits()
{
return $this->hits;
}
/**
* Returns the number of cache read misses.
*
* @return int
*/
public function getMisses()
{
return $this->misses;
}
private function getId($key)
{
CacheItem::validateKey($key);

17
src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterTest.php
View File

@ -29,21 +29,4 @@ class ProxyAdapterTest extends CachePoolTest
{
return new ProxyAdapter(new ArrayAdapter());
}
public function testGetHitsMisses()
{
$pool = $this->createCachePool();
$this->assertSame(0, $pool->getHits());
$this->assertSame(0, $pool->getMisses());
$bar = $pool->getItem('bar');
$this->assertSame(0, $pool->getHits());
$this->assertSame(1, $pool->getMisses());
$pool->save($bar->set('baz'));
$bar = $pool->getItem('bar');
$this->assertSame(1, $pool->getHits());
$this->assertSame(1, $pool->getMisses());
}
}