Make MessengerPass less strict when auto-register handlers
This commit is contained in:
parent
7b03bff57a
commit
49ab2cd9d9
@ -206,11 +206,11 @@ class MessengerPass implements CompilerPassInterface
|
|||||||
throw new RuntimeException(sprintf('Invalid handler service "%s": class "%s" must have an "__invoke()" method.', $serviceId, $handlerClass->getName()));
|
throw new RuntimeException(sprintf('Invalid handler service "%s": class "%s" must have an "__invoke()" method.', $serviceId, $handlerClass->getName()));
|
||||||
}
|
}
|
||||||
|
|
||||||
$parameters = $method->getParameters();
|
if (0 === $method->getNumberOfRequiredParameters()) {
|
||||||
if (1 !== \count($parameters)) {
|
throw new RuntimeException(sprintf('Invalid handler service "%s": method "%s::__invoke()" requires at least one argument, first one being the message it handles.', $serviceId, $handlerClass->getName()));
|
||||||
throw new RuntimeException(sprintf('Invalid handler service "%s": method "%s::__invoke()" must have exactly one argument corresponding to the message it handles.', $serviceId, $handlerClass->getName()));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$parameters = $method->getParameters();
|
||||||
if (!$type = $parameters[0]->getType()) {
|
if (!$type = $parameters[0]->getType()) {
|
||||||
throw new RuntimeException(sprintf('Invalid handler service "%s": argument "$%s" of method "%s::__invoke()" must have a type-hint corresponding to the message class it handles.', $serviceId, $parameters[0]->getName(), $handlerClass->getName()));
|
throw new RuntimeException(sprintf('Invalid handler service "%s": argument "$%s" of method "%s::__invoke()" must have a type-hint corresponding to the message class it handles.', $serviceId, $parameters[0]->getName(), $handlerClass->getName()));
|
||||||
}
|
}
|
||||||
|
@ -391,7 +391,7 @@ class MessengerPassTest extends TestCase
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException
|
* @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException
|
||||||
* @expectedExceptionMessage Invalid handler service "Symfony\Component\Messenger\Tests\DependencyInjection\MissingArgumentHandler": method "Symfony\Component\Messenger\Tests\DependencyInjection\MissingArgumentHandler::__invoke()" must have exactly one argument corresponding to the message it handles.
|
* @expectedExceptionMessage Invalid handler service "Symfony\Component\Messenger\Tests\DependencyInjection\MissingArgumentHandler": method "Symfony\Component\Messenger\Tests\DependencyInjection\MissingArgumentHandler::__invoke()" requires at least one argument, first one being the message it handles.
|
||||||
*/
|
*/
|
||||||
public function testMissingArgumentHandler()
|
public function testMissingArgumentHandler()
|
||||||
{
|
{
|
||||||
|
Reference in New Issue
Block a user