Merge branch '2.2' into 2.3
* 2.2: fixed CS {HttpFoundation] [Session] fixed session compatibility with memcached/redis session storage fixed CS Fixes for hasParameterOption and getParameterOption methods of ArgvInput
This commit is contained in:
commit
49eb608b72
@ -284,11 +284,13 @@ class ArgvInput extends Input
|
||||
{
|
||||
$values = (array) $values;
|
||||
|
||||
foreach ($this->tokens as $v) {
|
||||
if (in_array($v, $values)) {
|
||||
foreach ($this->tokens as $token) {
|
||||
foreach ($values as $value) {
|
||||
if ($token === $value || 0 === strpos($token, $value.'=')) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
@ -311,7 +313,7 @@ class ArgvInput extends Input
|
||||
$tokens = $this->tokens;
|
||||
while ($token = array_shift($tokens)) {
|
||||
foreach ($values as $value) {
|
||||
if (0 === strpos($token, $value)) {
|
||||
if ($token === $value || 0 === strpos($token, $value.'=')) {
|
||||
if (false !== $pos = strpos($token, '=')) {
|
||||
return substr($token, $pos + 1);
|
||||
}
|
||||
|
@ -273,6 +273,9 @@ class ArgvInputTest extends \PHPUnit_Framework_TestCase
|
||||
|
||||
$input = new ArgvInput(array('cli.php', 'foo'));
|
||||
$this->assertFalse($input->hasParameterOption('--foo'), '->hasParameterOption() returns false if the given short option is not in the raw input');
|
||||
|
||||
$input = new ArgvInput(array('cli.php', '--foo=bar'));
|
||||
$this->assertTrue($input->hasParameterOption('--foo'), '->hasParameterOption() returns true if the given option with provided value is in the raw input');
|
||||
}
|
||||
|
||||
public function testToString()
|
||||
@ -300,6 +303,7 @@ class ArgvInputTest extends \PHPUnit_Framework_TestCase
|
||||
array(array('app/console', 'foo:bar', '--env=dev'), '--env', 'dev'),
|
||||
array(array('app/console', 'foo:bar', '-e', 'dev'), array('-e', '--env'), 'dev'),
|
||||
array(array('app/console', 'foo:bar', '--env=dev'), array('-e', '--env'), 'dev'),
|
||||
array(array('app/console', 'foo:bar', '--env=dev', '--en=1'), array('--en'), '1'),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
@ -210,6 +210,7 @@ class NativeSessionStorage implements SessionStorageInterface
|
||||
$ret = session_regenerate_id($destroy);
|
||||
|
||||
// workaround for https://bugs.php.net/bug.php?id=61470 as suggested by David Grudl
|
||||
if ('files' === $this->getSaveHandler()->getSaveHandlerName()) {
|
||||
session_write_close();
|
||||
if (isset($_SESSION)) {
|
||||
$backup = $_SESSION;
|
||||
@ -218,6 +219,7 @@ class NativeSessionStorage implements SessionStorageInterface
|
||||
} else {
|
||||
session_start();
|
||||
}
|
||||
}
|
||||
|
||||
return $ret;
|
||||
}
|
||||
|
Reference in New Issue
Block a user