minor #17487 [2.3] [CS] MethodSeparationFixer - findings. (SpacePossum)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [CS] MethodSeparationFixer - findings.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Th goal of this PR is _not_ to have it merged, but to see if the `MethodSeparationFixer` (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1426) is suitable for SF level/configuration in the PHP-CS-Fixer (and thereby might later become part of `fabbot.io`).

Commits
-------

d7b730f Fixer findings.
This commit is contained in:
Fabien Potencier 2016-01-25 08:27:13 +01:00
commit 4b9f6c7aa8
9 changed files with 13 additions and 0 deletions

View File

@ -36,6 +36,7 @@ class TransNodeTest extends \PHPUnit_Framework_TestCase
trim($compiler->compile($node)->getSource()) trim($compiler->compile($node)->getSource())
); );
} }
protected function getVariableGetterWithoutStrictCheck($name) protected function getVariableGetterWithoutStrictCheck($name)
{ {
if (PHP_VERSION_ID >= 50400) { if (PHP_VERSION_ID >= 50400) {

View File

@ -82,6 +82,7 @@ abstract class AbstractDescriptorTest extends \PHPUnit_Framework_TestCase
} }
abstract protected function getDescriptor(); abstract protected function getDescriptor();
abstract protected function getFormat(); abstract protected function getFormat();
private function getDescriptionTestData(array $objects) private function getDescriptionTestData(array $objects)

View File

@ -28,5 +28,6 @@ abstract class AbstractNodeTest extends \PHPUnit_Framework_TestCase
} }
abstract public function getToStringConversionTestData(); abstract public function getToStringConversionTestData();
abstract public function getSpecificityValueTestData(); abstract public function getSpecificityValueTestData();
} }

View File

@ -43,7 +43,9 @@ abstract class AbstractHandlerTest extends \PHPUnit_Framework_TestCase
} }
abstract public function getHandleValueTestData(); abstract public function getHandleValueTestData();
abstract public function getDontHandleValueTestData(); abstract public function getDontHandleValueTestData();
abstract protected function generateHandler(); abstract protected function generateHandler();
protected function assertStreamEmpty(TokenStream $stream) protected function assertStreamEmpty(TokenStream $stream)

View File

@ -28,6 +28,7 @@ class HttpFoundationRequestHandlerTest extends AbstractRequestHandlerTest
{ {
$this->requestHandler->handleRequest($this->getMockForm('name', 'GET')); $this->requestHandler->handleRequest($this->getMockForm('name', 'GET'));
} }
/** /**
* @expectedException \Symfony\Component\Form\Exception\UnexpectedTypeException * @expectedException \Symfony\Component\Form\Exception\UnexpectedTypeException
*/ */

View File

@ -977,6 +977,7 @@ class Response
} }
// http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html // http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
/** /**
* Is response invalid? * Is response invalid?
* *

View File

@ -65,6 +65,7 @@ class Renderer extends RoutableFragmentRenderer
public function render($uri, Request $request, array $options = array()) public function render($uri, Request $request, array $options = array())
{ {
} }
public function getName() public function getName()
{ {
} }

View File

@ -85,15 +85,19 @@ class SomeUser implements UserInterface
public function getRoles() public function getRoles()
{ {
} }
public function getPassword() public function getPassword()
{ {
} }
public function getSalt() public function getSalt()
{ {
} }
public function getUsername() public function getUsername()
{ {
} }
public function eraseCredentials() public function eraseCredentials()
{ {
} }

View File

@ -87,6 +87,7 @@ class AnnotationLoaderTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expected_parent, $parent_metadata); $this->assertEquals($expected_parent, $parent_metadata);
} }
/** /**
* Test MetaData merge with parent annotation. * Test MetaData merge with parent annotation.
*/ */