diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #40798 Fix CS in IsbnValidator and IssnValidator (guilliamxavier)

Browse Source 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Fix CS in IsbnValidator and IssnValidator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

dc90c195e3 Fix CS in IsbnValidator and IssnValidator
This commit is contained in:
Nyholm 2021-04-14 11:41:21 +02:00
commit 4c9fce835d
No known key found for this signature in database
GPG Key ID: D6332DE2B6F8FA38
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Validator/Constraints/IsbnValidator.php
View File

@ -163,8 +163,7 @@ class IsbnValidator extends ConstraintValidator
}
for ($i = 1; $i < 12; $i += 2) {
$checkSum += $isbn[$i]
* 3;
$checkSum += $isbn[$i] * 3;
}
return 0 === $checkSum % 10 ? true : Isbn::CHECKSUM_FAILED_ERROR;

5
src/Symfony/Component/Validator/Constraints/IssnValidator.php
View File

@ -114,10 +114,7 @@ class IssnValidator extends ConstraintValidator
}
// Calculate a checksum. "X" equals 10.
$checkSum = 'X' === $canonical[7]
|| 'x' === $canonical[7]
? 10
: $canonical[7];
$checkSum = 'X' === $canonical[7] || 'x' === $canonical[7] ? 10 : $canonical[7];
for ($i = 0; $i < 7; ++$i) {
// Multiply the first digit by 8, the second by 7, etc.