minor #40798 Fix CS in IsbnValidator and IssnValidator (guilliamxavier)
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Fix CS in IsbnValidator and IssnValidator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
dc90c195e3
Fix CS in IsbnValidator and IssnValidator
This commit is contained in:
commit
4c9fce835d
@ -163,8 +163,7 @@ class IsbnValidator extends ConstraintValidator
|
|||||||
}
|
}
|
||||||
|
|
||||||
for ($i = 1; $i < 12; $i += 2) {
|
for ($i = 1; $i < 12; $i += 2) {
|
||||||
$checkSum += $isbn[$i]
|
$checkSum += $isbn[$i] * 3;
|
||||||
* 3;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0 === $checkSum % 10 ? true : Isbn::CHECKSUM_FAILED_ERROR;
|
return 0 === $checkSum % 10 ? true : Isbn::CHECKSUM_FAILED_ERROR;
|
||||||
|
@ -114,10 +114,7 @@ class IssnValidator extends ConstraintValidator
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Calculate a checksum. "X" equals 10.
|
// Calculate a checksum. "X" equals 10.
|
||||||
$checkSum = 'X' === $canonical[7]
|
$checkSum = 'X' === $canonical[7] || 'x' === $canonical[7] ? 10 : $canonical[7];
|
||||||
|| 'x' === $canonical[7]
|
|
||||||
? 10
|
|
||||||
: $canonical[7];
|
|
||||||
|
|
||||||
for ($i = 0; $i < 7; ++$i) {
|
for ($i = 0; $i < 7; ++$i) {
|
||||||
// Multiply the first digit by 8, the second by 7, etc.
|
// Multiply the first digit by 8, the second by 7, etc.
|
||||||
|
Reference in New Issue
Block a user