diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #24979 [HttpKernel] remove services resetter even when it's an alias (xabbuh)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] remove services resetter even when it's an alias

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

All the other places in the compiler pass do not care whether the
resetter service is aliased or not. Let's just also properly deal with
the case that the services resetter service was aliased by another
bundle.

Commits
-------

f7e634b remove services resetter even when it's an alias
This commit is contained in:
Nicolas Grekas 2017-11-16 23:50:23 +02:00
commit 4fadbcdc58
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/HttpKernel/DependencyInjection/ResettableServicePass.php
View File

@ -53,6 +53,7 @@ class ResettableServicePass implements CompilerPassInterface
}
if (empty($services)) {
$container->removeAlias('services_resetter');
$container->removeDefinition('services_resetter');
return;