From 4fcb24bacb8caa1cfa4fe74a7c25a72b9a6e5a71 Mon Sep 17 00:00:00 2001 From: apetitpa Date: Thu, 23 Mar 2017 13:36:20 +0100 Subject: [PATCH] Move empty condition in return statement --- .../Validator/Constraints/EmailValidator.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/EmailValidator.php b/src/Symfony/Component/Validator/Constraints/EmailValidator.php index 3eee66fcd8..cd635eb136 100644 --- a/src/Symfony/Component/Validator/Constraints/EmailValidator.php +++ b/src/Symfony/Component/Validator/Constraints/EmailValidator.php @@ -138,11 +138,7 @@ class EmailValidator extends ConstraintValidator */ private function checkMX($host) { - if ('' === $host) { - return false; - } - - return checkdnsrr($host, 'MX'); + return ('' !== $host) && checkdnsrr($host, 'MX'); } /** @@ -154,10 +150,6 @@ class EmailValidator extends ConstraintValidator */ private function checkHost($host) { - if ('' === $host) { - return false; - } - - return $this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA')); + return ('' !== $host) && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA'))); } }