diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[HttpFoundation] use atomic writes in MockFileSessionStorage

Browse Source
This commit is contained in:
Nicolas Grekas 2021-01-13 14:01:18 +01:00
parent d23b74ebce
commit 5290e978bd
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Symfony/Component/HttpFoundation/Session/Storage/MockFileSessionStorage.php
View File

@ -103,7 +103,10 @@ class MockFileSessionStorage extends MockArraySessionStorage
try { try {
if ($data) { if ($data) {
file_put_contents($this->getFilePath(), serialize($data)); $path = $this->getFilePath();
$tmp = $path.bin2hex(random_bytes(6));
file_put_contents($tmp, serialize($data));
rename($tmp, $path);
} else { } else {
$this->destroy(); $this->destroy();
} }
@ -123,8 +126,11 @@ class MockFileSessionStorage extends MockArraySessionStorage
*/ */
private function destroy(): void private function destroy(): void
{ {
if (is_file($this->getFilePath())) { set_error_handler(static function () {});
try {
unlink($this->getFilePath()); unlink($this->getFilePath());
} finally {
restore_error_handler();
} }
} }
@ -141,8 +147,14 @@ class MockFileSessionStorage extends MockArraySessionStorage
*/ */
private function read(): void private function read(): void
{ {
$filePath = $this->getFilePath(); set_error_handler(static function () {});
$this->data = is_readable($filePath) && is_file($filePath) ? unserialize(file_get_contents($filePath)) : []; try {
$data = file_get_contents($this->getFilePath());
} finally {
restore_error_handler();
}
$this->data = $data ? unserialize($data) : [];
$this->loadSession(); $this->loadSession();
} }