diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #11964 [Tests] PHPUnit Optimizations (lyrixx)

Browse Source 
This PR was merged into the 2.4 branch.

Discussion
----------

[Tests] PHPUnit Optimizations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

957fbb2 [Tests] PHPUnit Optimizations
This commit is contained in:
Fabien Potencier 2014-09-20 08:00:46 +02:00
commit 5647e695f5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/WriteCheckSessionHandlerTest.php
View File

@ -30,7 +30,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue(true))
;
$this->assertEquals(true, $writeCheckSessionHandler->close());
$this->assertTrue($writeCheckSessionHandler->close());
}
public function testWrite()
@ -45,7 +45,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue(true))
;
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'bar'));
$this->assertTrue($writeCheckSessionHandler->write('foo', 'bar'));
}
public function testSkippedWrite()
@ -66,7 +66,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
;
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'bar'));
$this->assertTrue($writeCheckSessionHandler->write('foo', 'bar'));
}
public function testNonSkippedWrite()
@ -89,6 +89,6 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
;
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'baZZZ'));
$this->assertTrue($writeCheckSessionHandler->write('foo', 'baZZZ'));
}
}