minor #11964 [Tests] PHPUnit Optimizations (lyrixx)
This PR was merged into the 2.4 branch.
Discussion
----------
[Tests] PHPUnit Optimizations
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
957fbb2
[Tests] PHPUnit Optimizations
This commit is contained in:
commit
5647e695f5
@ -30,7 +30,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
|
|||||||
->will($this->returnValue(true))
|
->will($this->returnValue(true))
|
||||||
;
|
;
|
||||||
|
|
||||||
$this->assertEquals(true, $writeCheckSessionHandler->close());
|
$this->assertTrue($writeCheckSessionHandler->close());
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testWrite()
|
public function testWrite()
|
||||||
@ -45,7 +45,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
|
|||||||
->will($this->returnValue(true))
|
->will($this->returnValue(true))
|
||||||
;
|
;
|
||||||
|
|
||||||
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'bar'));
|
$this->assertTrue($writeCheckSessionHandler->write('foo', 'bar'));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testSkippedWrite()
|
public function testSkippedWrite()
|
||||||
@ -66,7 +66,7 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
|
|||||||
;
|
;
|
||||||
|
|
||||||
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
|
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
|
||||||
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'bar'));
|
$this->assertTrue($writeCheckSessionHandler->write('foo', 'bar'));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testNonSkippedWrite()
|
public function testNonSkippedWrite()
|
||||||
@ -89,6 +89,6 @@ class WriteCheckSessionHandlerTest extends \PHPUnit_Framework_TestCase
|
|||||||
;
|
;
|
||||||
|
|
||||||
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
|
$this->assertEquals('bar', $writeCheckSessionHandler->read('foo'));
|
||||||
$this->assertEquals(true, $writeCheckSessionHandler->write('foo', 'baZZZ'));
|
$this->assertTrue($writeCheckSessionHandler->write('foo', 'baZZZ'));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user