bug #26356 [FrameworkBundle] HttpCache is not longer abstract (lyrixx)
This PR was merged into the 2.7 branch.
Discussion
----------
[FrameworkBundle] HttpCache is not longer abstract
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
---
I don't really know why this class was abstract in the first place.
But it's not needed. A fresh symfony 4 application can use this class
directly without extending it.
Commits
-------
4d075da
[FrameworkBundle] HttpCache is not longer abstract
This commit is contained in:
commit
56856da3a1
@ -11,7 +11,7 @@
|
||||
|
||||
namespace Symfony\Bundle\FrameworkBundle\HttpCache;
|
||||
|
||||
use Symfony\Component\HttpKernel\HttpKernelInterface;
|
||||
use Symfony\Component\HttpKernel\KernelInterface;
|
||||
use Symfony\Component\HttpKernel\HttpCache\HttpCache as BaseHttpCache;
|
||||
use Symfony\Component\HttpKernel\HttpCache\Esi;
|
||||
use Symfony\Component\HttpKernel\HttpCache\Store;
|
||||
@ -23,16 +23,16 @@ use Symfony\Component\HttpFoundation\Response;
|
||||
*
|
||||
* @author Fabien Potencier <fabien@symfony.com>
|
||||
*/
|
||||
abstract class HttpCache extends BaseHttpCache
|
||||
class HttpCache extends BaseHttpCache
|
||||
{
|
||||
protected $cacheDir;
|
||||
protected $kernel;
|
||||
|
||||
/**
|
||||
* @param HttpKernelInterface $kernel An HttpKernelInterface instance
|
||||
* @param string $cacheDir The cache directory (default used if null)
|
||||
* @param KernelInterface $kernel A KernelInterface instance
|
||||
* @param string $cacheDir The cache directory (default used if null)
|
||||
*/
|
||||
public function __construct(HttpKernelInterface $kernel, $cacheDir = null)
|
||||
public function __construct(KernelInterface $kernel, $cacheDir = null)
|
||||
{
|
||||
$this->kernel = $kernel;
|
||||
$this->cacheDir = $cacheDir;
|
||||
|
Reference in New Issue
Block a user