diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Workflow] Fixed BC break for Workflow metadata

Browse Source
This commit is contained in:
Grégoire Pineau 2018-12-03 19:01:20 +01:00
parent a256c6914d
commit 5691818397
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View File

@ -525,7 +525,7 @@ class FrameworkExtension extends Extension
} }
if ($transition['metadata']) { if ($transition['metadata']) {
$transitionsMetadataDefinition->addMethodCall('attach', array( $transitionsMetadataDefinition->addMethodCall('attach', array(
$transitionDefinition, new Reference($transitionId),
$transition['metadata'], $transition['metadata'],
)); ));
} }
@ -547,7 +547,7 @@ class FrameworkExtension extends Extension
} }
if ($transition['metadata']) { if ($transition['metadata']) {
$transitionsMetadataDefinition->addMethodCall('attach', array( $transitionsMetadataDefinition->addMethodCall('attach', array(
$transitionDefinition, new Reference($transitionId),
$transition['metadata'], $transition['metadata'],
)); ));
} }

6
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
View File

@ -256,10 +256,8 @@ abstract class FrameworkExtensionTest extends TestCase
$this->assertSame('attach', $transitionsMetadataCall[0]); $this->assertSame('attach', $transitionsMetadataCall[0]);
$params = $transitionsMetadataCall[1]; $params = $transitionsMetadataCall[1];
$this->assertCount(2, $params); $this->assertCount(2, $params);
$this->assertInstanceOf(Definition::class, $params[0]); $this->assertInstanceOf(Reference::class, $params[0]);
$this->assertSame(Workflow\Transition::class, $params[0]->getClass()); $this->assertSame('state_machine.pull_request.transition.0', (string) $params[0]);
$this->assertSame(array('submit', 'start', 'travis'), $params[0]->getArguments());
$this->assertSame(array('title' => 'transition submit title'), $params[1]);
$serviceMarkingStoreWorkflowDefinition = $container->getDefinition('workflow.service_marking_store_workflow'); $serviceMarkingStoreWorkflowDefinition = $container->getDefinition('workflow.service_marking_store_workflow');
/** @var Reference $markingStoreRef */ /** @var Reference $markingStoreRef */