merged branch Inori/refactor-naming (PR #4767)
Commits
-------
819fe34
[Form] refactored variable name to be more consistent with rest of the naming
Discussion
----------
[Form] Refactored config variable naming to be more consistent
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Since `clientTransformer` is renamed to `viewTransformer` everywhere, I think for consistency reasons config variable name should be changed too..
---------------------------------------------------------------------------
by stloyd at 2012-07-06T07:31:39Z
Maybe also rename of `normTransformers` to `modelTransformers` ? As this were changed too.
---------------------------------------------------------------------------
by Inori at 2012-07-06T07:40:53Z
@stloyd makes sense, done
---------------------------------------------------------------------------
by bschussek at 2012-07-06T08:24:43Z
Thanks for the cleanup. Can you squash the commits and prefix the message with "[Form]" please?
---------------------------------------------------------------------------
by Inori at 2012-07-06T08:43:49Z
@bschussek done
---------------------------------------------------------------------------
by bschussek at 2012-07-06T09:31:04Z
Thanks! @fabpot 👍
This commit is contained in:
commit
57581193d3
@ -65,12 +65,12 @@ class UnmodifiableFormConfig implements FormConfigInterface
|
||||
/**
|
||||
* @var array
|
||||
*/
|
||||
private $clientTransformers;
|
||||
private $viewTransformers;
|
||||
|
||||
/**
|
||||
* @var array
|
||||
*/
|
||||
private $normTransformers;
|
||||
private $modelTransformers;
|
||||
|
||||
/**
|
||||
* @var DataMapperInterface
|
||||
@ -142,8 +142,8 @@ class UnmodifiableFormConfig implements FormConfigInterface
|
||||
$this->virtual = $config->getVirtual();
|
||||
$this->compound = $config->getCompound();
|
||||
$this->types = $config->getTypes();
|
||||
$this->clientTransformers = $config->getViewTransformers();
|
||||
$this->normTransformers = $config->getModelTransformers();
|
||||
$this->viewTransformers = $config->getViewTransformers();
|
||||
$this->modelTransformers = $config->getModelTransformers();
|
||||
$this->dataMapper = $config->getDataMapper();
|
||||
$this->validators = $config->getValidators();
|
||||
$this->required = $config->getRequired();
|
||||
@ -225,7 +225,7 @@ class UnmodifiableFormConfig implements FormConfigInterface
|
||||
*/
|
||||
public function getViewTransformers()
|
||||
{
|
||||
return $this->clientTransformers;
|
||||
return $this->viewTransformers;
|
||||
}
|
||||
|
||||
/**
|
||||
@ -233,7 +233,7 @@ class UnmodifiableFormConfig implements FormConfigInterface
|
||||
*/
|
||||
public function getModelTransformers()
|
||||
{
|
||||
return $this->normTransformers;
|
||||
return $this->modelTransformers;
|
||||
}
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user