diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch Inori/refactor-naming (PR #4767)

Browse Source 
Commits
-------

819fe34 [Form] refactored variable name to be more consistent with rest of the naming

Discussion
----------

[Form] Refactored config variable naming to be more consistent

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

Since `clientTransformer` is renamed to `viewTransformer` everywhere, I think for consistency reasons config variable name should be changed too..

---------------------------------------------------------------------------

by stloyd at 2012-07-06T07:31:39Z

Maybe also rename of `normTransformers` to `modelTransformers` ? As this were changed too.

---------------------------------------------------------------------------

by Inori at 2012-07-06T07:40:53Z

@stloyd makes sense, done

---------------------------------------------------------------------------

by bschussek at 2012-07-06T08:24:43Z

Thanks for the cleanup. Can you squash the commits and prefix the message with "[Form]" please?

---------------------------------------------------------------------------

by Inori at 2012-07-06T08:43:49Z

@bschussek done

---------------------------------------------------------------------------

by bschussek at 2012-07-06T09:31:04Z

Thanks! @fabpot 👍
This commit is contained in:
Fabien Potencier 2012-07-06 12:00:31 +02:00
commit 57581193d3
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Symfony/Component/Form/UnmodifiableFormConfig.php
View File

@ -65,12 +65,12 @@ class UnmodifiableFormConfig implements FormConfigInterface
/** /**
* @var array * @var array
*/ */
private $clientTransformers; private $viewTransformers;
/** /**
* @var array * @var array
*/ */
private $normTransformers; private $modelTransformers;
/** /**
* @var DataMapperInterface * @var DataMapperInterface
@ -142,8 +142,8 @@ class UnmodifiableFormConfig implements FormConfigInterface
$this->virtual = $config->getVirtual(); $this->virtual = $config->getVirtual();
$this->compound = $config->getCompound(); $this->compound = $config->getCompound();
$this->types = $config->getTypes(); $this->types = $config->getTypes();
$this->clientTransformers = $config->getViewTransformers(); $this->viewTransformers = $config->getViewTransformers();
$this->normTransformers = $config->getModelTransformers(); $this->modelTransformers = $config->getModelTransformers();
$this->dataMapper = $config->getDataMapper(); $this->dataMapper = $config->getDataMapper();
$this->validators = $config->getValidators(); $this->validators = $config->getValidators();
$this->required = $config->getRequired(); $this->required = $config->getRequired();
@ -225,7 +225,7 @@ class UnmodifiableFormConfig implements FormConfigInterface
*/ */
public function getViewTransformers() public function getViewTransformers()
{ {
return $this->clientTransformers; return $this->viewTransformers;
} }
/** /**
@ -233,7 +233,7 @@ class UnmodifiableFormConfig implements FormConfigInterface
*/ */
public function getModelTransformers() public function getModelTransformers()
{ {
return $this->normTransformers; return $this->modelTransformers;
} }
/** /**