diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #27158 [Cache] fix logic for fetching tag versions on TagAwareAdapter (dmaicher)

Browse Source 
This PR was squashed before being merged into the 3.4 branch (closes #27158).

Discussion
----------

[Cache] fix logic for fetching tag versions on TagAwareAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27147
| License       | MIT
| Doc PR        | -

There was a problem introduced in https://github.com/symfony/symfony/pull/27007 which breaks tag invalidation.

From what I can see there were some cases when the actual tag versions were never fetched from the tags pool and version=0 was used.

@nicolas-grekas this is my attempt of understanding the logic within `TagAwareAdapter`. Please have a look if this makes sense to you 😉

Commits
-------

d3790cadcd [Cache] fix logic for fetching tag versions on TagAwareAdapter
This commit is contained in:
Nicolas Grekas 2018-05-04 19:07:18 -07:00
commit 5aaa0d72c2
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
View File

@ -345,6 +345,7 @@ class TagAwareAdapter implements TagAwareAdapterInterface, PruneableInterface, R
foreach ($tagVersions as $tag => $version) {
$tags[$tag.static::TAGS_PREFIX] = $tag;
if ($fetchTagVersions || !isset($this->knownTagVersions[$tag])) {
$fetchTagVersions = true;
continue;
}
$version -= $this->knownTagVersions[$tag][1];

6
src/Symfony/Component/Cache/Tests/Adapter/TagAwareAdapterTest.php
View File

@ -69,6 +69,12 @@ class TagAwareAdapterTest extends AdapterTestCase
$this->assertFalse($pool->getItem('i1')->isHit());
$this->assertFalse($pool->getItem('i3')->isHit());
$this->assertTrue($pool->getItem('foo')->isHit());
$anotherPoolInstance = $this->createCachePool();
$this->assertFalse($anotherPoolInstance->getItem('i1')->isHit());
$this->assertFalse($anotherPoolInstance->getItem('i3')->isHit());
$this->assertTrue($anotherPoolInstance->getItem('foo')->isHit());
}
public function testInvalidateCommits()