From e861500ce82ee5e55903440bbd947315389fcd3f Mon Sep 17 00:00:00 2001 From: Maxime Helias Date: Wed, 1 Apr 2020 10:54:50 +0200 Subject: [PATCH] [Form] action allows only strings --- src/Symfony/Component/Form/Extension/Core/Type/FormType.php | 1 + .../Form/Tests/Extension/Core/Type/FormTypeTest.php | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/src/Symfony/Component/Form/Extension/Core/Type/FormType.php b/src/Symfony/Component/Form/Extension/Core/Type/FormType.php index 57e39617fd..6ef9159c23 100644 --- a/src/Symfony/Component/Form/Extension/Core/Type/FormType.php +++ b/src/Symfony/Component/Form/Extension/Core/Type/FormType.php @@ -203,6 +203,7 @@ class FormType extends BaseType ]); $resolver->setAllowedTypes('label_attr', 'array'); + $resolver->setAllowedTypes('action', 'string'); $resolver->setAllowedTypes('upload_max_size_message', ['callable']); $resolver->setAllowedTypes('help', ['string', 'null']); $resolver->setAllowedTypes('help_attr', 'array'); diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php index 066bed2174..f5cb83190b 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php @@ -341,6 +341,12 @@ class FormTypeTest extends BaseTypeTest $this->factory->create(static::TESTED_TYPE, null, ['attr' => '']); } + public function testActionCannotBeNull() + { + $this->expectException('Symfony\Component\OptionsResolver\Exception\InvalidOptionsException'); + $this->factory->create(static::TESTED_TYPE, null, ['action' => null]); + } + public function testNameCanBeEmptyString() { $form = $this->factory->createNamed('', static::TESTED_TYPE);