diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #38945 [Finder] Force set access time in test (Nyholm) 

This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] Force set access time in test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no, it only updates the tests
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38942
| License       | MIT
| Doc PR        |

OSX don't really update atime (access time). They claim it is because performance reasons. So this PR will update the test to make PHP force access time on a file.

The different runs of `testAccept` depends on each other because each test modifies the filesystem a bit. That is why I added the extra `sleep(1)`.

Commits
-------

c5ec51abdf [Finder] Force set access time in test
This commit is contained in:
Fabien Potencier 2020-11-02 07:48:36 +01:00
parent 20306a23bf c5ec51abdf
commit 5c3781ae18
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Finder/Tests/Iterator/SortableIteratorTest.php
View File

@ -35,9 +35,10 @@ class SortableIteratorTest extends RealIteratorTestCase
case SortableIterator::SORT_BY_ACCESSED_TIME:
touch(self::toAbsolute('.git'));
sleep(1);
file_get_contents(self::toAbsolute('.bar'));
touch(self::toAbsolute('.bar'), time());
break;
case SortableIterator::SORT_BY_CHANGED_TIME:
sleep(1);
file_put_contents(self::toAbsolute('test.php'), 'foo');
sleep(1);
file_put_contents(self::toAbsolute('test.py'), 'foo');