[HttpKernel][Client] Only simple (name=value without any other params) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265
This commit is contained in:
parent
75dfc7945a
commit
5c41ec9e4f
@ -169,7 +169,7 @@ EOF;
|
|||||||
foreach ($response->headers->getCookies() as $cookie) {
|
foreach ($response->headers->getCookies() as $cookie) {
|
||||||
$cookies[] = new DomCookie($cookie->getName(), $cookie->getValue(), $cookie->getExpiresTime(), $cookie->getPath(), $cookie->getDomain(), $cookie->isSecure(), $cookie->isHttpOnly());
|
$cookies[] = new DomCookie($cookie->getName(), $cookie->getValue(), $cookie->getExpiresTime(), $cookie->getPath(), $cookie->getDomain(), $cookie->isSecure(), $cookie->isHttpOnly());
|
||||||
}
|
}
|
||||||
$headers['Set-Cookie'] = implode(', ', $cookies);
|
$headers['Set-Cookie'] = $cookies;
|
||||||
}
|
}
|
||||||
|
|
||||||
return new DomResponse($response->getContent(), $response->getStatusCode(), $headers);
|
return new DomResponse($response->getContent(), $response->getStatusCode(), $headers);
|
||||||
|
@ -66,16 +66,22 @@ class ClientTest extends \PHPUnit_Framework_TestCase
|
|||||||
$m = $r->getMethod('filterResponse');
|
$m = $r->getMethod('filterResponse');
|
||||||
$m->setAccessible(true);
|
$m->setAccessible(true);
|
||||||
|
|
||||||
|
$expected = array(
|
||||||
|
'foo=bar; expires=Sun, 15 Feb 2009 20:00:00 GMT; domain=http://example.com; path=/foo; secure; httponly',
|
||||||
|
'foo1=bar1; expires=Sun, 15 Feb 2009 20:00:00 GMT; domain=http://example.com; path=/foo; secure; httponly'
|
||||||
|
);
|
||||||
|
|
||||||
$response = new Response();
|
$response = new Response();
|
||||||
$response->headers->setCookie(new Cookie('foo', 'bar', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
$response->headers->setCookie(new Cookie('foo', 'bar', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
||||||
$domResponse = $m->invoke($client, $response);
|
$domResponse = $m->invoke($client, $response);
|
||||||
$this->assertEquals('foo=bar; expires=Sun, 15 Feb 2009 20:00:00 GMT; domain=http://example.com; path=/foo; secure; httponly', $domResponse->getHeader('Set-Cookie'));
|
$this->assertEquals($expected[0], $domResponse->getHeader('Set-Cookie'));
|
||||||
|
|
||||||
$response = new Response();
|
$response = new Response();
|
||||||
$response->headers->setCookie(new Cookie('foo', 'bar', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
$response->headers->setCookie(new Cookie('foo', 'bar', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
||||||
$response->headers->setCookie(new Cookie('foo1', 'bar1', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
$response->headers->setCookie(new Cookie('foo1', 'bar1', \DateTime::createFromFormat('j-M-Y H:i:s T', '15-Feb-2009 20:00:00 GMT')->format('U'), '/foo', 'http://example.com', true, true));
|
||||||
$domResponse = $m->invoke($client, $response);
|
$domResponse = $m->invoke($client, $response);
|
||||||
$this->assertEquals('foo=bar; expires=Sun, 15 Feb 2009 20:00:00 GMT; domain=http://example.com; path=/foo; secure; httponly, foo1=bar1; expires=Sun, 15 Feb 2009 20:00:00 GMT; domain=http://example.com; path=/foo; secure; httponly', $domResponse->getHeader('Set-Cookie'));
|
$this->assertEquals($expected[0], $domResponse->getHeader('Set-Cookie'));
|
||||||
|
$this->assertEquals($expected, $domResponse->getHeader('Set-Cookie', false));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testUploadedFile()
|
public function testUploadedFile()
|
||||||
|
Reference in New Issue
Block a user