diff --git a/src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php index 9d14007fde..cb0876d541 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\RedisAdapter; @@ -32,12 +33,12 @@ abstract class AbstractRedisAdapterTest extends AdapterTestCase public static function setUpBeforeClass(): void { if (!\extension_loaded('redis')) { - self::markTestSkipped('Extension redis required.'); + throw new SkippedTestSuiteError('Extension redis required.'); } try { (new \Redis())->connect(getenv('REDIS_HOST')); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Cache/Tests/Adapter/CouchbaseBucketAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/CouchbaseBucketAdapterTest.php index c72d6710f2..8862e54cb2 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/CouchbaseBucketAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/CouchbaseBucketAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\AbstractAdapter; use Symfony\Component\Cache\Adapter\CouchbaseBucketAdapter; @@ -34,7 +35,7 @@ class CouchbaseBucketAdapterTest extends AdapterTestCase public static function setupBeforeClass(): void { if (!CouchbaseBucketAdapter::isSupported()) { - self::markTestSkipped('Couchbase >= 2.6.0 < 3.0.0 is required.'); + throw new SkippedTestSuiteError('Couchbase >= 2.6.0 < 3.0.0 is required.'); } self::$client = AbstractAdapter::createConnection('couchbase://'.getenv('COUCHBASE_HOST').'/cache', diff --git a/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php index 0a67ea1846..1a1faed9e7 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\AbstractAdapter; use Symfony\Component\Cache\Adapter\MemcachedAdapter; @@ -32,14 +33,14 @@ class MemcachedAdapterTest extends AdapterTestCase public static function setUpBeforeClass(): void { if (!MemcachedAdapter::isSupported()) { - self::markTestSkipped('Extension memcached >=2.2.0 required.'); + throw new SkippedTestSuiteError('Extension memcached >=2.2.0 required.'); } self::$client = AbstractAdapter::createConnection('memcached://'.getenv('MEMCACHED_HOST'), ['binary_protocol' => false]); self::$client->get('foo'); $code = self::$client->getResultCode(); if (\Memcached::RES_SUCCESS !== $code && \Memcached::RES_NOTFOUND !== $code) { - self::markTestSkipped('Memcached error: '.strtolower(self::$client->getResultMessage())); + throw new SkippedTestSuiteError('Memcached error: '.strtolower(self::$client->getResultMessage())); } } diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php index 3540155685..95c0fd6f8a 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\PdoAdapter; @@ -26,7 +27,7 @@ class PdoAdapterTest extends AdapterTestCase public static function setUpBeforeClass(): void { if (!\extension_loaded('pdo_sqlite')) { - self::markTestSkipped('Extension pdo_sqlite required.'); + throw new SkippedTestSuiteError('Extension pdo_sqlite required.'); } self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache'); diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PdoDbalAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PdoDbalAdapterTest.php index 0e5dd36bfb..46c4599dc5 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/PdoDbalAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/PdoDbalAdapterTest.php @@ -15,6 +15,7 @@ use Doctrine\DBAL\Connection; use Doctrine\DBAL\Driver\AbstractMySQLDriver; use Doctrine\DBAL\DriverManager; use Doctrine\DBAL\Schema\Schema; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\PdoAdapter; @@ -30,7 +31,7 @@ class PdoDbalAdapterTest extends AdapterTestCase public static function setUpBeforeClass(): void { if (!\extension_loaded('pdo_sqlite')) { - self::markTestSkipped('Extension pdo_sqlite required.'); + throw new SkippedTestSuiteError('Extension pdo_sqlite required.'); } self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache'); diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php index 9db83c0db4..4367ce0bfa 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\Cache\Adapter\RedisAdapter; /** @@ -21,7 +22,7 @@ class PredisRedisClusterAdapterTest extends AbstractRedisAdapterTest public static function setUpBeforeClass(): void { if (!$hosts = getenv('REDIS_CLUSTER_HOSTS')) { - self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.'); } self::$redis = RedisAdapter::createConnection('redis:?host['.str_replace(' ', ']&host[', $hosts).']', ['class' => \Predis\Client::class, 'redis_cluster' => true, 'prefix' => 'prefix_']); diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterSentinelTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterSentinelTest.php index 20f0811863..c8b3ce9b9d 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterSentinelTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterSentinelTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\Cache\Adapter\AbstractAdapter; use Symfony\Component\Cache\Adapter\RedisAdapter; use Symfony\Component\Cache\Exception\InvalidArgumentException; @@ -23,13 +24,13 @@ class RedisAdapterSentinelTest extends AbstractRedisAdapterTest public static function setUpBeforeClass(): void { if (!class_exists(\Predis\Client::class)) { - self::markTestSkipped('The Predis\Client class is required.'); + throw new SkippedTestSuiteError('The Predis\Client class is required.'); } if (!$hosts = getenv('REDIS_SENTINEL_HOSTS')) { - self::markTestSkipped('REDIS_SENTINEL_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_SENTINEL_HOSTS env var is not defined.'); } if (!$service = getenv('REDIS_SENTINEL_SERVICE')) { - self::markTestSkipped('REDIS_SENTINEL_SERVICE env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_SENTINEL_SERVICE env var is not defined.'); } self::$redis = AbstractAdapter::createConnection('redis:?host['.str_replace(' ', ']&host[', $hosts).']', ['redis_sentinel' => $service, 'prefix' => 'prefix_']); diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php index 6e0b448746..f9d481dba7 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @group integration */ @@ -20,7 +22,7 @@ class RedisArrayAdapterTest extends AbstractRedisAdapterTest { parent::setupBeforeClass(); if (!class_exists(\RedisArray::class)) { - self::markTestSkipped('The RedisArray class is required.'); + throw new SkippedTestSuiteError('The RedisArray class is required.'); } self::$redis = new \RedisArray([getenv('REDIS_HOST')], ['lazy_connect' => true]); self::$redis->setOption(\Redis::OPT_PREFIX, 'prefix_'); diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php index 011a36b338..fca50690ae 100644 --- a/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php +++ b/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Cache\Tests\Adapter; +use PHPUnit\Framework\SkippedTestSuiteError; use Psr\Cache\CacheItemPoolInterface; use Symfony\Component\Cache\Adapter\AbstractAdapter; use Symfony\Component\Cache\Adapter\RedisAdapter; @@ -25,10 +26,10 @@ class RedisClusterAdapterTest extends AbstractRedisAdapterTest public static function setUpBeforeClass(): void { if (!class_exists(\RedisCluster::class)) { - self::markTestSkipped('The RedisCluster class is required.'); + throw new SkippedTestSuiteError('The RedisCluster class is required.'); } if (!$hosts = getenv('REDIS_CLUSTER_HOSTS')) { - self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.'); } self::$redis = AbstractAdapter::createConnection('redis:?host['.str_replace(' ', ']&host[', $hosts).']', ['lazy' => true, 'redis_cluster' => true]); diff --git a/src/Symfony/Component/Console/Input/Input.php b/src/Symfony/Component/Console/Input/Input.php index d34e94e913..23f94efb54 100644 --- a/src/Symfony/Component/Console/Input/Input.php +++ b/src/Symfony/Component/Console/Input/Input.php @@ -106,7 +106,7 @@ abstract class Input implements InputInterface, StreamableInputInterface */ public function getArgument($name) { - if (!$this->definition->hasArgument($name)) { + if (!$this->definition->hasArgument((string) $name)) { throw new InvalidArgumentException(sprintf('The "%s" argument does not exist.', $name)); } @@ -118,7 +118,7 @@ abstract class Input implements InputInterface, StreamableInputInterface */ public function setArgument($name, $value) { - if (!$this->definition->hasArgument($name)) { + if (!$this->definition->hasArgument((string) $name)) { throw new InvalidArgumentException(sprintf('The "%s" argument does not exist.', $name)); } @@ -130,7 +130,7 @@ abstract class Input implements InputInterface, StreamableInputInterface */ public function hasArgument($name) { - return $this->definition->hasArgument($name); + return $this->definition->hasArgument((string) $name); } /** diff --git a/src/Symfony/Component/Console/Input/InputInterface.php b/src/Symfony/Component/Console/Input/InputInterface.php index da4a1b8bda..53affba38d 100644 --- a/src/Symfony/Component/Console/Input/InputInterface.php +++ b/src/Symfony/Component/Console/Input/InputInterface.php @@ -83,7 +83,7 @@ interface InputInterface /** * Returns the argument value for a given argument name. * - * @param string|int $name The InputArgument name or position + * @param string $name The argument name * * @return mixed * @@ -94,8 +94,8 @@ interface InputInterface /** * Sets an argument value by name. * - * @param string|int $name The InputArgument name or position - * @param mixed $value The argument value + * @param string $name The argument name + * @param mixed $value The argument value * * @throws InvalidArgumentException When argument given doesn't exist */ @@ -104,7 +104,7 @@ interface InputInterface /** * Returns true if an InputArgument object exists by name or position. * - * @param string|int $name The InputArgument name or position + * @param string $name The InputArgument name or position * * @return bool true if the InputArgument object exists, false otherwise */ diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php index 4554e3bce8..df6ef3073a 100644 --- a/src/Symfony/Component/DependencyInjection/Container.php +++ b/src/Symfony/Component/DependencyInjection/Container.php @@ -378,9 +378,7 @@ class Container implements ContainerInterface, ResetInterface $this->set($id, new ServiceLocator([])); } if (!$this->getEnv) { - $this->getEnv = new \ReflectionMethod($this, __FUNCTION__); - $this->getEnv->setAccessible(true); - $this->getEnv = $this->getEnv->getClosure($this); + $this->getEnv = \Closure::fromCallable([$this, 'getEnv']); } $processors = $this->get($id); diff --git a/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php b/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php index 4b236a5b43..f788ddb94f 100644 --- a/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php +++ b/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php @@ -98,7 +98,7 @@ class RegisterListenersPass implements CompilerPassInterface if (!isset($event['method'])) { $event['method'] = 'on'.preg_replace_callback([ - '/(?<=\b)[a-z]/i', + '/(?<=\b|_)[a-z]/i', '/[^a-z0-9]/i', ], function ($matches) { return strtoupper($matches[0]); }, $event['event']); $event['method'] = preg_replace('/[^a-z0-9]/i', '', $event['method']); diff --git a/src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php b/src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php index bf2cebf6c0..ddd75c3401 100644 --- a/src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php +++ b/src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php @@ -196,6 +196,7 @@ class RegisterListenersPassTest extends TestCase $container->register('foo', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']); $container->register('bar', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']); $container->register('baz', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'event']); + $container->register('zar', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar_zar']); $container->register('event_dispatcher', \stdClass::class); $registerListenersPass = new RegisterListenersPass(); @@ -227,6 +228,14 @@ class RegisterListenersPassTest extends TestCase 0, ], ], + [ + 'addListener', + [ + 'foo.bar_zar', + [new ServiceClosureArgument(new Reference('zar')), 'onFooBarZar'], + 0, + ], + ], ]; $this->assertEquals($expectedCalls, $definition->getMethodCalls()); } diff --git a/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php b/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php index d5296e1fbc..7ad91fd6bf 100644 --- a/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php +++ b/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php @@ -11,6 +11,7 @@ namespace Symfony\Component\HttpClient\Tests; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\HttpClient\Exception\ClientException; use Symfony\Component\HttpClient\Exception\TransportException; use Symfony\Component\HttpClient\Internal\ClientState; @@ -295,11 +296,11 @@ abstract class HttpClientTestCase extends BaseHttpClientTestCase } if ('\\' === \DIRECTORY_SEPARATOR) { - self::markTestSkipped('Testing with the "vulcain" is not supported on Windows.'); + throw new SkippedTestSuiteError('Testing with the "vulcain" is not supported on Windows.'); } if (['application/json'] !== $client->request('GET', 'http://127.0.0.1:8057/json')->getHeaders()['content-type']) { - self::markTestSkipped('symfony/http-client-contracts >= 2.0.1 required'); + throw new SkippedTestSuiteError('symfony/http-client-contracts >= 2.0.1 required'); } $process = new Process(['vulcain'], null, [ @@ -316,14 +317,14 @@ abstract class HttpClientTestCase extends BaseHttpClientTestCase if (!$process->isRunning()) { if ('\\' !== \DIRECTORY_SEPARATOR && 127 === $process->getExitCode()) { - self::markTestSkipped('vulcain binary is missing'); + throw new SkippedTestSuiteError('vulcain binary is missing'); } if ('\\' !== \DIRECTORY_SEPARATOR && 126 === $process->getExitCode()) { - self::markTestSkipped('vulcain binary is not executable'); + throw new SkippedTestSuiteError('vulcain binary is not executable'); } - self::markTestSkipped((new ProcessFailedException($process))->getMessage()); + throw new SkippedTestSuiteError((new ProcessFailedException($process))->getMessage()); } self::$vulcainStarted = true; diff --git a/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php b/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php index 49acff5abc..471455d708 100644 --- a/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php +++ b/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\HttpFoundation\Tests; +use PHPUnit\Framework\SkippedTestSuiteError; use PHPUnit\Framework\TestCase; class ResponseFunctionalTest extends TestCase @@ -24,7 +25,7 @@ class ResponseFunctionalTest extends TestCase 2 => ['file', '/dev/null', 'w'], ]; if (!self::$server = @proc_open('exec '.\PHP_BINARY.' -S localhost:8054', $spec, $pipes, __DIR__.'/Fixtures/response-functional')) { - self::markTestSkipped('PHP server unable to start.'); + throw new SkippedTestSuiteError('PHP server unable to start.'); } sleep(1); } diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractSessionHandlerTest.php index 45257abb98..f6417720d2 100644 --- a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractSessionHandlerTest.php +++ b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractSessionHandlerTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler; +use PHPUnit\Framework\SkippedTestSuiteError; use PHPUnit\Framework\TestCase; class AbstractSessionHandlerTest extends TestCase @@ -24,7 +25,7 @@ class AbstractSessionHandlerTest extends TestCase 2 => ['file', '/dev/null', 'w'], ]; if (!self::$server = @proc_open('exec '.\PHP_BINARY.' -S localhost:8053', $spec, $pipes, __DIR__.'/Fixtures')) { - self::markTestSkipped('PHP server unable to start.'); + throw new SkippedTestSuiteError('PHP server unable to start.'); } sleep(1); } diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/RedisClusterSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/RedisClusterSessionHandlerTest.php index e9471a5414..b3b7b4a1ff 100644 --- a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/RedisClusterSessionHandlerTest.php +++ b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/RedisClusterSessionHandlerTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @group integration */ @@ -19,11 +21,11 @@ class RedisClusterSessionHandlerTest extends AbstractRedisSessionHandlerTestCase public static function setUpBeforeClass(): void { if (!class_exists(\RedisCluster::class)) { - self::markTestSkipped('The RedisCluster class is required.'); + throw new SkippedTestSuiteError('The RedisCluster class is required.'); } if (!$hosts = getenv('REDIS_CLUSTER_HOSTS')) { - self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.'); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php index fa93d0c570..a0b308d2ab 100644 --- a/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Lock\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\Lock\Exception\InvalidTtlException; use Symfony\Component\Lock\Key; use Symfony\Component\Lock\PersistingStoreInterface; @@ -34,7 +35,7 @@ class MemcachedStoreTest extends AbstractStoreTest $code = $memcached->getResultCode(); if (\Memcached::RES_SUCCESS !== $code && \Memcached::RES_NOTFOUND !== $code) { - self::markTestSkipped('Unable to connect to the memcache host'); + throw new SkippedTestSuiteError('Unable to connect to the memcache host'); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php index cd6ab0a47b..4922778374 100644 --- a/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php @@ -13,6 +13,7 @@ namespace Symfony\Component\Lock\Tests\Store; use MongoDB\Client; use MongoDB\Driver\Exception\ConnectionTimeoutException; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\Lock\Exception\InvalidArgumentException; use Symfony\Component\Lock\Key; use Symfony\Component\Lock\PersistingStoreInterface; @@ -31,14 +32,14 @@ class MongoDbStoreTest extends AbstractStoreTest public static function setupBeforeClass(): void { if (!class_exists(\MongoDB\Client::class)) { - self::markTestSkipped('The mongodb/mongodb package is required.'); + throw new SkippedTestSuiteError('The mongodb/mongodb package is required.'); } $client = self::getMongoClient(); try { $client->listDatabases(); } catch (ConnectionTimeoutException $e) { - self::markTestSkipped('MongoDB server not found.'); + throw new SkippedTestSuiteError('MongoDB server not found.'); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php index 3a53cd9d40..7dc483bf84 100644 --- a/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Lock\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @group integration @@ -23,7 +25,7 @@ class PredisStoreTest extends AbstractRedisStoreTest try { $redis->connect(); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php index fb87944a00..0e5ac73e9b 100644 --- a/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Lock\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @@ -22,12 +24,12 @@ class RedisArrayStoreTest extends AbstractRedisStoreTest public static function setUpBeforeClass(): void { if (!class_exists(\RedisArray::class)) { - self::markTestSkipped('The RedisArray class is required.'); + throw new SkippedTestSuiteError('The RedisArray class is required.'); } try { (new \Redis())->connect(getenv('REDIS_HOST')); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php index 454493f1ef..387a9033ad 100644 --- a/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Lock\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @@ -22,10 +24,10 @@ class RedisClusterStoreTest extends AbstractRedisStoreTest public static function setUpBeforeClass(): void { if (!class_exists(\RedisCluster::class)) { - self::markTestSkipped('The RedisCluster class is required.'); + throw new SkippedTestSuiteError('The RedisCluster class is required.'); } if (!getenv('REDIS_CLUSTER_HOSTS')) { - self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.'); } } diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php index 4aaa607338..9f45bae927 100644 --- a/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php +++ b/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Lock\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; use Symfony\Component\Lock\Exception\InvalidTtlException; use Symfony\Component\Lock\Store\RedisStore; @@ -29,7 +30,7 @@ class RedisStoreTest extends AbstractRedisStoreTest try { (new \Redis())->connect(getenv('REDIS_HOST')); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php index 554b1f92cd..d24b91f032 100644 --- a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php +++ b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Messenger\Bridge\Redis\Tests\Transport; +use PHPUnit\Framework\SkippedTestSuiteError; use PHPUnit\Framework\TestCase; use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait; use Symfony\Component\Messenger\Bridge\Redis\Transport\Connection; @@ -31,12 +32,12 @@ class ConnectionTest extends TestCase $redis->get(); } catch (TransportException $e) { if (0 === strpos($e->getMessage(), 'ERR unknown command \'X')) { - self::markTestSkipped('Redis server >= 5 is required'); + throw new SkippedTestSuiteError('Redis server >= 5 is required'); } throw $e; } catch (\RedisException $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php b/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php index 2be5a50ded..24506f1e9d 100644 --- a/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php +++ b/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php @@ -11,7 +11,6 @@ namespace Symfony\Component\Security\Core\Tests\Validator\Constraints; -use Foo\Bar\User; use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; use Symfony\Component\Security\Core\Authentication\Token\TokenInterface; use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface; @@ -25,7 +24,7 @@ use Symfony\Component\Validator\Test\ConstraintValidatorTestCase; /** * @author Bernhard Schussek */ -abstract class UserPasswordValidatorTest extends ConstraintValidatorTestCase +class UserPasswordValidatorTest extends ConstraintValidatorTestCase { private const PASSWORD = 's3Cr3t'; private const SALT = '^S4lt$'; @@ -126,7 +125,7 @@ abstract class UserPasswordValidatorTest extends ConstraintValidatorTestCase public function testUserIsNotValid() { $this->expectException(ConstraintDefinitionException::class); - $user = $this->createMock(User::class); + $user = new \stdClass(); $this->tokenStorage = $this->createTokenStorage($user); $this->validator = $this->createValidator(); diff --git a/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentTokenBasedRememberMeServicesTest.php b/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentTokenBasedRememberMeServicesTest.php index 0efda325d3..6868873142 100644 --- a/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentTokenBasedRememberMeServicesTest.php +++ b/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentTokenBasedRememberMeServicesTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Security\Http\Tests\RememberMe; +use PHPUnit\Framework\SkippedTestSuiteError; use PHPUnit\Framework\TestCase; use Symfony\Component\HttpFoundation\Cookie; use Symfony\Component\HttpFoundation\Request; @@ -34,7 +35,7 @@ class PersistentTokenBasedRememberMeServicesTest extends TestCase try { random_bytes(1); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Semaphore/Tests/Store/PredisStoreTest.php b/src/Symfony/Component/Semaphore/Tests/Store/PredisStoreTest.php index cc4d5a766e..bf1d2c0641 100644 --- a/src/Symfony/Component/Semaphore/Tests/Store/PredisStoreTest.php +++ b/src/Symfony/Component/Semaphore/Tests/Store/PredisStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Semaphore\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé */ @@ -22,7 +24,7 @@ class PredisStoreTest extends AbstractRedisStoreTest try { $redis->connect(); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Semaphore/Tests/Store/RedisArrayStoreTest.php b/src/Symfony/Component/Semaphore/Tests/Store/RedisArrayStoreTest.php index 7e1cbe96e1..9de3d2af79 100644 --- a/src/Symfony/Component/Semaphore/Tests/Store/RedisArrayStoreTest.php +++ b/src/Symfony/Component/Semaphore/Tests/Store/RedisArrayStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Semaphore\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @@ -21,12 +23,12 @@ class RedisArrayStoreTest extends AbstractRedisStoreTest public static function setUpBeforeClass(): void { if (!class_exists(\RedisArray::class)) { - self::markTestSkipped('The RedisArray class is required.'); + throw new SkippedTestSuiteError('The RedisArray class is required.'); } try { (new \Redis())->connect(getenv('REDIS_HOST')); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Semaphore/Tests/Store/RedisClusterStoreTest.php b/src/Symfony/Component/Semaphore/Tests/Store/RedisClusterStoreTest.php index 0087300e58..be463d52d0 100644 --- a/src/Symfony/Component/Semaphore/Tests/Store/RedisClusterStoreTest.php +++ b/src/Symfony/Component/Semaphore/Tests/Store/RedisClusterStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Semaphore\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @@ -21,10 +23,10 @@ class RedisClusterStoreTest extends AbstractRedisStoreTest public static function setUpBeforeClass(): void { if (!class_exists(\RedisCluster::class)) { - self::markTestSkipped('The RedisCluster class is required.'); + throw new SkippedTestSuiteError('The RedisCluster class is required.'); } if (!getenv('REDIS_CLUSTER_HOSTS')) { - self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.'); + throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.'); } } diff --git a/src/Symfony/Component/Semaphore/Tests/Store/RedisStoreTest.php b/src/Symfony/Component/Semaphore/Tests/Store/RedisStoreTest.php index ac35eef424..52725a6ac1 100644 --- a/src/Symfony/Component/Semaphore/Tests/Store/RedisStoreTest.php +++ b/src/Symfony/Component/Semaphore/Tests/Store/RedisStoreTest.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Semaphore\Tests\Store; +use PHPUnit\Framework\SkippedTestSuiteError; + /** * @author Jérémy Derussé * @@ -28,7 +30,7 @@ class RedisStoreTest extends AbstractRedisStoreTest try { (new \Redis())->connect(getenv('REDIS_HOST')); } catch (\Exception $e) { - self::markTestSkipped($e->getMessage()); + throw new SkippedTestSuiteError($e->getMessage()); } } diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf index 8a4b0d606a..aa136b92e3 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf @@ -386,6 +386,10 @@ This value is not a valid International Securities Identification Number (ISIN). Стойността не е валиден Международен идентификационен номер на ценни книжа (ISIN). + + This value should be a valid expression. + Стойността трябва да бъде валиден израз. + diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf index 1a99117f93..c3b3365701 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf @@ -386,6 +386,10 @@ This value is not a valid International Securities Identification Number (ISIN). この値は有効な国際証券識別番号(ISIN)ではありません。 + + This value should be a valid expression. + 式でなければなりません。 + diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf index 952195172a..09dd68036f 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf @@ -386,6 +386,10 @@ This value is not a valid International Securities Identification Number (ISIN). Giá trị này không phải là mã số chứng khoán quốc tế (ISIN) hợp lệ. + + This value should be a valid expression. + Giá trị này phải là một biểu thức hợp lệ. +