diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #13085 [FrameworkBundle] Fix dependency on ExtensionInterface over implementation (xphere)

Browse Source 
This PR was merged into the 2.5 branch.

Discussion
----------

[FrameworkBundle] Fix dependency on ExtensionInterface over implementation

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no (but anyway, they didn't pass previously)
| Fixed tickets | #13084
| License       | MIT

When implementing `ExtensionInterface` through classes not inheriting the core `Extension`, the command `config:dump` throws.
This bug was introduced in 2.5 and could be fixed up to 2.7 with the same patch.

Commits
-------

5e1a5f7 fix dependency on ExtensionInterface over implementation
This commit is contained in:
Fabien Potencier 2014-12-23 18:18:54 +01:00
commit 5e0ae268c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Bundle/FrameworkBundle/Command/AbstractConfigCommand.php
View File

@ -13,7 +13,7 @@ namespace Symfony\Bundle\FrameworkBundle\Command;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
/**
* A console command for dumping available configuration reference.
@ -73,7 +73,7 @@ abstract class AbstractConfigCommand extends ContainerDebugCommand
return $extension;
}
public function validateConfiguration(Extension $extension, $configuration)
public function validateConfiguration(ExtensionInterface $extension, $configuration)
{
if (!$configuration) {
throw new \LogicException(sprintf('The extension with alias "%s" does not have its getConfiguration() method setup', $extension->getAlias()));