bug #36868 [Validator] Use Mime component to determine mime type for file validator (pierredup)
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Use Mime component to determine mime type for file validator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
When validating the mime type for a file, the Validator component relies on the `Symfony\Component\HttpFoundation\File\File` class, but if the HttpFoundation component is not installed, then you just get the error
```
PHP Fatal error: Uncaught Error: Class 'Symfony\Component\HttpFoundation\File\File' not found
```
This PR uses the Mime component to get the mime type for a file and throws an exception if the Mime component is not installed.
Commits
-------
472883313f
[Validator] Use Mime component to determine mime type for file validator
This commit is contained in:
commit
5e0e9a8019
@ -13,8 +13,10 @@ namespace Symfony\Component\Validator\Constraints;
|
|||||||
|
|
||||||
use Symfony\Component\HttpFoundation\File\File as FileObject;
|
use Symfony\Component\HttpFoundation\File\File as FileObject;
|
||||||
use Symfony\Component\HttpFoundation\File\UploadedFile;
|
use Symfony\Component\HttpFoundation\File\UploadedFile;
|
||||||
|
use Symfony\Component\Mime\MimeTypes;
|
||||||
use Symfony\Component\Validator\Constraint;
|
use Symfony\Component\Validator\Constraint;
|
||||||
use Symfony\Component\Validator\ConstraintValidator;
|
use Symfony\Component\Validator\ConstraintValidator;
|
||||||
|
use Symfony\Component\Validator\Exception\LogicException;
|
||||||
use Symfony\Component\Validator\Exception\UnexpectedTypeException;
|
use Symfony\Component\Validator\Exception\UnexpectedTypeException;
|
||||||
use Symfony\Component\Validator\Exception\UnexpectedValueException;
|
use Symfony\Component\Validator\Exception\UnexpectedValueException;
|
||||||
|
|
||||||
@ -170,12 +172,17 @@ class FileValidator extends ConstraintValidator
|
|||||||
}
|
}
|
||||||
|
|
||||||
if ($constraint->mimeTypes) {
|
if ($constraint->mimeTypes) {
|
||||||
if (!$value instanceof FileObject) {
|
if ($value instanceof FileObject) {
|
||||||
$value = new FileObject($value);
|
$mime = $value->getMimeType();
|
||||||
|
} elseif (class_exists(MimeTypes::class)) {
|
||||||
|
$mime = MimeTypes::getDefault()->guessMimeType($path);
|
||||||
|
} elseif (!class_exists(FileObject::class)) {
|
||||||
|
throw new LogicException('You cannot validate the mime-type of files as the Mime component is not installed. Try running "composer require symfony/mime".');
|
||||||
|
} else {
|
||||||
|
$mime = (new FileObject($value))->getMimeType();
|
||||||
}
|
}
|
||||||
|
|
||||||
$mimeTypes = (array) $constraint->mimeTypes;
|
$mimeTypes = (array) $constraint->mimeTypes;
|
||||||
$mime = $value->getMimeType();
|
|
||||||
|
|
||||||
foreach ($mimeTypes as $mimeType) {
|
foreach ($mimeTypes as $mimeType) {
|
||||||
if ($mimeType === $mime) {
|
if ($mimeType === $mime) {
|
||||||
|
Reference in New Issue
Block a user