diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33760 [HttpKernel] drop support for retrieving container from non-booted kernels (xabbuh) 

This PR was merged into the 5.0-dev branch.

Discussion
----------

[HttpKernel] drop support for retrieving container from non-booted kernels

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

81ae635100 drop support for retrieving container from non-booted kernels
This commit is contained in:
Christian Flothmann 2019-09-30 16:37:48 +02:00
parent b15ae9c5e0 81ae635100
commit 5e48c39f79
3 changed files with 2 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/HttpKernel/CHANGELOG.md
View File

@ -4,6 +4,7 @@ CHANGELOG
5.0.0
-----
* removed support for getting the container from a non-booted kernel
* removed the first and second constructor argument of `ConfigDataCollector`
* removed `ConfigDataCollector::getApplicationName()`
* removed `ConfigDataCollector::getApplicationVersion()`

2
src/Symfony/Component/HttpKernel/Kernel.php
View File

@ -301,7 +301,7 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl
public function getContainer()
{
if (!$this->booted) {
@trigger_error('Getting the container from a non-booted kernel is deprecated since Symfony 4.4.', E_USER_DEPRECATED);
throw new \LogicException('Cannot retrieve the container from a non-booted kernel.');
}
return $this->container;

24
src/Symfony/Component/HttpKernel/Tests/KernelTest.php
View File

@ -47,18 +47,6 @@ class KernelTest extends TestCase
$this->assertLessThanOrEqual(microtime(true), $kernel->getStartTime());
}
/**
* @group legacy
* @expectedDeprecation Getting the container from a non-booted kernel is deprecated since Symfony 4.4.
*/
public function testGetContainerForANonBootedKernel()
{
$kernel = new KernelForTest('test_env', true);
$this->assertFalse($kernel->isBooted());
$this->assertNull($kernel->getContainer());
}
public function testClone()
{
$env = 'test_env';
@ -407,18 +395,6 @@ EOF;
$kernel->terminate(Request::create('/'), new Response());
}
/**
* @group legacy
* @expectedDeprecation Getting the container from a non-booted kernel is deprecated since Symfony 4.4.
*/
public function testDeprecatedNullKernel()
{
$kernel = $this->getKernel();
$kernel->shutdown();
$this->assertNull($kernel->getContainer());
}
public function testTerminateDelegatesTerminationOnlyForTerminableInterface()
{
// does not implement TerminableInterface