diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #34903 Fixing bad order of operations with null coalescing operator (weaverryan) 

This PR was merged into the 4.4 branch.

Discussion
----------

Fixing bad order of operations with null coalescing operator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | None
| License       | MIT
| Doc PR        | not needed

Hi!

Reported by a user on SymfonyCasts :). Apparently without the parentheses, the order of operations is incorrect: https://3v4l.org/UZ7GU

Thanks!

Commits
-------

6291264 Fixing bad order of operations with null coalescing operator
This commit is contained in:
Yonel Ceruto 2019-12-09 16:15:29 -05:00
parent 6e44447e5d 629126435d
commit 5e75edf578
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php
View File

@ -41,7 +41,7 @@ class ProblemNormalizer implements NormalizerInterface, CacheableSupportsMethodI
public function normalize($exception, $format = null, array $context = [])
{
$context += $this->defaultContext;
$debug = $this->debug && $context['debug'] ?? true;
$debug = $this->debug && ($context['debug'] ?? true);
$data = [
'type' => $context['type'],