diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #17507 Update UPGRADE-3.0 with correct Voter details (jbafford) 

This PR was merged into the 2.8 branch.

Discussion
----------

Update UPGRADE-3.0 with correct Voter details

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets |
| License       | MIT
| Doc PR        |

AbstractVoter was removed, but the upgrade instructions to use Voter were not complete and continued to reference AbstractVoter.

Commits
-------

7b2a538 Update UPGRADE-3.0 with correct Voter details
This commit is contained in:
Fabien Potencier 2016-01-27 17:22:37 +01:00
parent 5d3d913404 7b2a538236
commit 5f5f4aa4cf
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
UPGRADE-3.0.md
View File

@ -898,11 +898,6 @@ UPGRADE FROM 2.x to 3.0
### Security
* The `AbstractVoter` class was removed in favor of the new `Voter` class.
* The `VoterInterface::supportsClass` and `supportsAttribute` methods were
removed from the interface.
* The `Resources/` directory was moved to `Core/Resources/`
* The `key` settings of `anonymous`, `remember_me` and `http_digest` are
@ -994,8 +989,15 @@ UPGRADE FROM 2.x to 3.0
));
```
* The `AbstractVoter::getSupportedAttributes()` and `AbstractVoter::getSupportedClasses()`
methods have been removed in favor of `AbstractVoter::supports()`.
* The `AbstractVoter` class was removed. Instead, extend the new `Voter` class,
introduced in 2.8, and move your voting logic to the to the `supports($attribute, $subject)`
and `voteOnAttribute($attribute, $object, TokenInterface $token)` methods.
* The `vote()` method from the `VoterInterface` was changed to now accept arbitrary
types, and not only objects.
* The `supportsClass` and `supportsAttribute` methods were
removed from the `VoterInterface` interface.
Before:
@ -1019,14 +1021,19 @@ UPGRADE FROM 2.x to 3.0
After:
```php
class MyVoter extends AbstractVoter
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
class MyVoter extends Voter
{
protected function supports($attribute, $object)
{
return $object instanceof Post && in_array($attribute, array('CREATE', 'EDIT'));
}
// ...
protected function voteOnAttribute($attribute, $object, TokenInterface $token)
{
// Return true or false
}
}
```