small optimization

2012-08-19 00:47:48 +04:00 · 2012-08-19 00:47:48 +04:00 · 630d16b8c7
commit 630d16b8c7
parent 7fe18d13a0
1 changed files with 10 additions and 4 deletions
--- a/src/Symfony/Component/Form/Guess/Guess.php
+++ b/src/Symfony/Component/Form/Guess/Guess.php
@ -79,11 +79,17 @@ abstract class Guess
     */
    public static function getBestGuess(array $guesses)
    {
-        usort($guesses, function ($a, $b) {
-            return $b->getConfidence() - $a->getConfidence();
-        });
+        $result = null;
+        $maxConfidence = -1;

-        return count($guesses) > 0 ? $guesses[0] : null;
+        foreach ($guesses as $guess) {
+            if ($maxConfidence < $confidence = $guess->getConfidence()) {
+                $maxConfidence = $confidence;
+                $result = $guess;
+            }
+        }
+
+        return $result;
    }

    /**