diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #20902 [Cache] Improve performances into foreach (PhpFilesAdapter) (hadjedjvincent)

Browse Source 
This PR was squashed before being merged into the 3.2 branch (closes #20902).

Discussion
----------

[Cache] Improve performances into foreach (PhpFilesAdapter)

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| License       | MIT

Let's prevent some useless call to be made into this foreach (ini_get)

Commits
-------

7e4573b [Cache] Improve performances into foreach (PhpFilesAdapter)
This commit is contained in:
Nicolas Grekas 2016-12-13 16:09:49 +01:00
commit 638533b532
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Cache/Adapter/PhpFilesAdapter.php
View File

@ -92,6 +92,7 @@ class PhpFilesAdapter extends AbstractAdapter
{
$ok = true;
$data = array($lifetime ? time() + $lifetime : PHP_INT_MAX, '');
$allowCompile = 'cli' !== PHP_SAPI || ini_get('opcache.enable_cli');
foreach ($values as $key => $value) {
if (null === $value || is_object($value)) {
@ -116,7 +117,7 @@ class PhpFilesAdapter extends AbstractAdapter
$file = $this->getFile($key, true);
$ok = $this->write($file, '<?php return '.var_export($data, true).';') && $ok;
if ('cli' !== PHP_SAPI || ini_get('opcache.enable_cli')) {
if ($allowCompile) {
@opcache_compile_file($file);
}
}