diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #28719 Correct PHPDoc type for float ttl (Soullivaneuh) 

This PR was merged into the 3.4 branch.

Discussion
----------

Correct PHPDoc type for float ttl

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

It can be null as the Lock instance accepts it.

It will fix that kind of PHPStan issue:

```
src/AppBundle/Command/AbstractCommand.php:45:Parameter #2 $ttl of method Symfony\Component\Lock\Factory::createLock() expects float, null given.
```

Commits
-------

b662e7eaf2 Correct PHPDoc type for float ttl
This commit is contained in:
Fabien Potencier 2018-10-06 18:30:02 +02:00
parent 155fab6e6f b662e7eaf2
commit 63d287b70c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Symfony/Component/Lock/Factory.php
View File

@ -36,9 +36,9 @@ class Factory implements LoggerAwareInterface
/**
* Creates a lock for the given resource.
*
* @param string $resource The resource to lock
* @param float $ttl Maximum expected lock duration in seconds
* @param bool $autoRelease Whether to automatically release the lock or not when the lock instance is destroyed
* @param string $resource The resource to lock
* @param float|null $ttl Maximum expected lock duration in seconds
* @param bool $autoRelease Whether to automatically release the lock or not when the lock instance is destroyed
*
* @return Lock
*/