diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch jakzal/master-fixme (PR #8480) 

This PR was merged into the master branch.

Discussion
----------

[DependencyInjection] Removed outdated FIXME comments.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I stumbled upon two FIXME comments in the `ContainerBulderTest` which were introduced in 7796eb21.

It looks like the intention was that parameters in the builder should be resolved without having to compile the container. Unless we agree to change the behaviour at this point (the change was introduced over 3 years ago), the comments should be removed.

Commits
-------

44f9322 [DependencyInjection] Removed outdated FIXME comments.
This commit is contained in:
Fabien Potencier 2013-07-12 12:48:53 +02:00
parent 2e650b16ea 44f932270a
commit 63e6368dc0
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
View File

@ -403,7 +403,6 @@ class ContainerBuilderTest extends \PHPUnit_Framework_TestCase
$container->setResourceTracking(false);
$config = new ContainerBuilder(new ParameterBag(array('foo' => '%bar%')));
$container->merge($config);
////// FIXME
$container->compile();
$this->assertEquals(array('bar' => 'foo', 'foo' => 'foo'), $container->getParameterBag()->all(), '->merge() evaluates the values of the parameters towards already defined ones');
@ -411,7 +410,6 @@ class ContainerBuilderTest extends \PHPUnit_Framework_TestCase
$container->setResourceTracking(false);
$config = new ContainerBuilder(new ParameterBag(array('foo' => '%bar%', 'baz' => '%foo%')));
$container->merge($config);
////// FIXME
$container->compile();
$this->assertEquals(array('bar' => 'foo', 'foo' => 'foo', 'baz' => 'foo'), $container->getParameterBag()->all(), '->merge() evaluates the values of the parameters towards already defined ones');