diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed underscores from test method names to be consistent with other components.

Browse Source 
It is more common to use fully camel-cased names for test methods. Only some of the test methods are called with underscore notation. To avoid confusion it is better to be consistent.
This commit is contained in:
Jakub Zalas 2013-01-25 21:14:24 +00:00 committed by Fabien Potencier
parent be69ca1648
commit 63f300613e
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Symfony/Component/PropertyAccess/Tests/PropertyPathTest.php
View File

@ -27,7 +27,7 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
*/
public function testInvalidPropertyPath_noDotBeforeProperty()
public function testDotIsRequiredBeforeProperty()
{
new PropertyPath('[index]property');
}
@ -35,7 +35,7 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
*/
public function testInvalidPropertyPath_dotAtTheBeginning()
public function testDotCannotBePresentAtTheBeginning()
{
new PropertyPath('.property');
}
@ -43,7 +43,7 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
*/
public function testInvalidPropertyPath_unexpectedCharacters()
public function testUnexpectedCharacters()
{
new PropertyPath('property.$foo');
}
@ -51,7 +51,7 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
*/
public function testInvalidPropertyPath_empty()
public function testPathCannotBeEmpty()
{
new PropertyPath('');
}
@ -59,7 +59,7 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\UnexpectedTypeException
*/
public function testInvalidPropertyPath_null()
public function testPathCannotBeNull()
{
new PropertyPath(null);
}
@ -67,31 +67,31 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
/**
* @expectedException \Symfony\Component\PropertyAccess\Exception\UnexpectedTypeException
*/
public function testInvalidPropertyPath_false()
public function testPathCannotBeFalse()
{
new PropertyPath(false);
}
public function testValidPropertyPath_zero()
public function testZeroIsValidPropertyPath()
{
new PropertyPath('0');
}
public function testGetParent_dot()
public function testGetParentWithDot()
{
$propertyPath = new PropertyPath('grandpa.parent.child');
$this->assertEquals(new PropertyPath('grandpa.parent'), $propertyPath->getParent());
}
public function testGetParent_index()
public function testGetParentWithIndex()
{
$propertyPath = new PropertyPath('grandpa.parent[child]');
$this->assertEquals(new PropertyPath('grandpa.parent'), $propertyPath->getParent());
}
public function testGetParent_noParent()
public function testGetParentWhenThereIsNoParent()
{
$propertyPath = new PropertyPath('path');