diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch jonathaningram/patch-6 (PR #3422)

Browse Source 
Commits
-------

88ccb9b Added another corner case
7c4343f Added 4 assertions related to simple URLs containing ? and #

Discussion
----------

[Validator] added assertions related to simple URLs containing ? and #

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

This adds 5 assertions for corner cases when validating a URL containing `?` and/or `#`.

Note: this does not actually fix any bugs, it just adds a few more cases.

I hope I've sent this to the correct branch - it's not a bug fix so I've not sent it to 2.0.x, but it's not a feature either...
This commit is contained in:
Fabien Potencier 2012-03-02 21:41:13 +01:00
commit 64132b9256
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/Symfony/Tests/Component/Validator/Constraints/UrlValidatorTest.php
View File

@ -79,7 +79,10 @@ class UrlValidatorTest extends \PHPUnit_Framework_TestCase
array('http://www.test-example.com/'),
array('http://www.symfony.com/'),
array('http://symfony.fake/blog/'),
array('http://symfony.com/?'),
array('http://symfony.com/search?type=&q=url+validator'),
array('http://symfony.com/#'),
array('http://symfony.com/#?'),
array('http://www.symfony.com/doc/current/book/validation.html#supported-constraints'),
array('http://very.long.domain.name.com/'),
array('http://127.0.0.1/'),
@ -129,6 +132,8 @@ class UrlValidatorTest extends \PHPUnit_Framework_TestCase
array('http://goog_le.com'),
array('http://google.com::aa'),
array('http://google.com:aa'),
array('http://symfony.com?'),
array('http://symfony.com#'),
array('ftp://google.fr'),
array('faked://google.fr'),
array('http://127.0.0.1:aa/'),