diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #38637 Enable Doctrine tests on php 8 (derrabus)

Browse Source 
This PR was merged into the 4.4 branch.

Discussion
----------

Enable Doctrine tests on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Continuation of #38636 on 4.4.

Commits
-------

c65c6ea75d Don't skip Doctrine tests on php 8.
This commit is contained in:
Fabien Potencier 2020-10-20 08:07:38 +02:00
commit 65b41dea0d
4 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php
View File

@ -11,7 +11,6 @@
namespace Symfony\Component\Cache\Tests\Adapter;
use Doctrine\DBAL\Version;
use Psr\Cache\CacheItemPoolInterface;
use Symfony\Component\Cache\Adapter\PdoAdapter;
use Symfony\Component\Cache\Tests\Traits\PdoPruneableTrait;
@ -31,10 +30,6 @@ class PdoAdapterTest extends AdapterTestCase
self::markTestSkipped('Extension pdo_sqlite required.');
}
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
}
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
$pool = new PdoAdapter('sqlite:'.self::$dbFile);

5
src/Symfony/Component/Lock/Tests/Store/PdoDbalStoreTest.php
View File

@ -12,7 +12,6 @@
namespace Symfony\Component\Lock\Tests\Store;
use Doctrine\DBAL\DriverManager;
use Doctrine\DBAL\Version;
use Symfony\Component\Lock\PersistingStoreInterface;
use Symfony\Component\Lock\Store\PdoStore;
@ -31,10 +30,6 @@ class PdoDbalStoreTest extends AbstractStoreTest
{
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
}
$store = new PdoStore(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));
$store->createTable();
}

5
src/Symfony/Component/Lock/Tests/Store/PdoStoreTest.php
View File

@ -11,7 +11,6 @@
namespace Symfony\Component\Lock\Tests\Store;
use Doctrine\DBAL\Version;
use Symfony\Component\Lock\Key;
use Symfony\Component\Lock\PersistingStoreInterface;
use Symfony\Component\Lock\Store\PdoStore;
@ -31,10 +30,6 @@ class PdoStoreTest extends AbstractStoreTest
{
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
}
$store = new PdoStore('sqlite:'.self::$dbFile);
$store->createTable();
}

8
src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineIntegrationTest.php
View File

@ -14,7 +14,6 @@ namespace Symfony\Component\Messenger\Tests\Transport\Doctrine;
use Doctrine\DBAL\Driver\Result as DriverResult;
use Doctrine\DBAL\DriverManager;
use Doctrine\DBAL\Result;
use Doctrine\DBAL\Version;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
use Symfony\Component\Messenger\Transport\Doctrine\Connection;
@ -31,13 +30,6 @@ class DoctrineIntegrationTest extends TestCase
/** @var string */
private $sqliteFile;
public static function setUpBeforeClass(): void
{
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
}
}
protected function setUp(): void
{
$this->sqliteFile = sys_get_temp_dir().'/symfony.messenger.sqlite';