minor #18139 [FrameworkBundle] Replace kernel.debug with member variable (patrick-mcdougle)
This PR was merged into the 2.7 branch.
Discussion
----------
[FrameworkBundle] Replace kernel.debug with member variable
| Q | A
| ------------- | ---
| Branch | 2.7
| Bug fix? | no
| New feature? | no
| BC breaks? | unlikely
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
While digging around I noticed that someone added debug to the constructor, but didn't replace all the `%kernel.debug%` strings. This PR is just to improve consistency.
Technically this could cause a BC break if someone was using a compiler pass to alter the argument of the constructor while the other config was relying on `%kernel.debug%`, but the likelihood of that is probably very low.
Commits
-------
181f256
Use debug member variable
This commit is contained in:
commit
67fba7dc1e
@ -654,7 +654,7 @@ class Configuration implements ConfigurationInterface
|
|||||||
->children()
|
->children()
|
||||||
->scalarNode('cache')->defaultValue('file')->end()
|
->scalarNode('cache')->defaultValue('file')->end()
|
||||||
->scalarNode('file_cache_dir')->defaultValue('%kernel.cache_dir%/annotations')->end()
|
->scalarNode('file_cache_dir')->defaultValue('%kernel.cache_dir%/annotations')->end()
|
||||||
->booleanNode('debug')->defaultValue('%kernel.debug%')->end()
|
->booleanNode('debug')->defaultValue($this->debug)->end()
|
||||||
->end()
|
->end()
|
||||||
->end()
|
->end()
|
||||||
->end()
|
->end()
|
||||||
|
@ -169,7 +169,7 @@ class ConfigurationTest extends \PHPUnit_Framework_TestCase
|
|||||||
'annotations' => array(
|
'annotations' => array(
|
||||||
'cache' => 'file',
|
'cache' => 'file',
|
||||||
'file_cache_dir' => '%kernel.cache_dir%/annotations',
|
'file_cache_dir' => '%kernel.cache_dir%/annotations',
|
||||||
'debug' => '%kernel.debug%',
|
'debug' => true,
|
||||||
),
|
),
|
||||||
'serializer' => array(
|
'serializer' => array(
|
||||||
'enabled' => false,
|
'enabled' => false,
|
||||||
|
Reference in New Issue
Block a user