From 0d4bce66763c58b74abf46d0278e63329768a6ef Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 20 Dec 2017 12:18:49 +0100 Subject: [PATCH] [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions --- src/Symfony/Component/Process/Process.php | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php index 4087dabc14..4bebbb4d9a 100644 --- a/src/Symfony/Component/Process/Process.php +++ b/src/Symfony/Component/Process/Process.php @@ -1718,15 +1718,11 @@ class Process implements \IteratorAggregate private function getDefaultEnv() { - if (\PHP_VERSION_ID >= 70100) { - $env = getenv(); - } else { - $env = array(); + $env = array(); - foreach ($_SERVER as $k => $v) { - if (is_string($v) && false !== $v = getenv($k)) { - $env[$k] = $v; - } + foreach ($_SERVER as $k => $v) { + if (is_string($v) && false !== $v = getenv($k)) { + $env[$k] = $v; } }