minor #38299 [ErrorHandler] Return false directly and remove unused variable (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] Return false directly and remove unused variable

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/37848
| License       | MIT
| Doc PR        | -

To return true, $type and $log both need to be true. But to enter the condition, one of them has to be false.

I also spotted an unused variable below so I removed it.

Commits
-------

3933957d1a [ErrorHandler] Return false directly and remove unused variable
This commit is contained in:
Nicolas Grekas 2020-09-25 11:42:25 +02:00
commit 6bb0ef4f52

View File

@ -419,9 +419,8 @@ class ErrorHandler
}
if (!$type || (!$log && !$throw)) {
return !$silenced && $type && $log;
return false;
}
$scope = $this->scopedErrors & $type;
if (false !== strpos($message, "@anonymous\0")) {
$logMessage = $this->parseAnonymousClass($message);