feature #33565 [Mailer] Rename an exception class (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Rename an exception class

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

2c58dcc34b [Mailer] Rename an exception class

src/Symfony/Component/Mailer/Bridge/Amazon/Tests/Transport/SesTransportFactoryTest.php

@@ -120,7 +120,7 @@ class SesTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('ses+foo', 'default', self::USER, self::PASSWORD),
-            'The "ses+foo" scheme is not supported. Supported schemes for mailer "ses" are: "ses", "ses+api", "ses+https", "ses+smtp", "ses+smtps".',
+            'The "ses+foo" scheme is not supported; supported schemes for mailer "ses" are: "ses", "ses+api", "ses+https", "ses+smtp", "ses+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Bridge/Google/Tests/Transport/GmailTransportFactoryTest.php

@@ -60,7 +60,7 @@ class GmailTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('gmail+foo', 'default', self::USER, self::PASSWORD),
-            'The "gmail+foo" scheme is not supported. Supported schemes for mailer "gmail" are: "gmail", "gmail+smtp", "gmail+smtps".',
+            'The "gmail+foo" scheme is not supported; supported schemes for mailer "gmail" are: "gmail", "gmail+smtp", "gmail+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Bridge/Mailchimp/Tests/Transport/MandrillTransportFactoryTest.php

@@ -105,7 +105,7 @@ class MandrillTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('mandrill+foo', 'default', self::USER),
-            'The "mandrill+foo" scheme is not supported. Supported schemes for mailer "mandrill" are: "mandrill", "mandrill+api", "mandrill+https", "mandrill+smtp", "mandrill+smtps".',
+            'The "mandrill+foo" scheme is not supported; supported schemes for mailer "mandrill" are: "mandrill", "mandrill+api", "mandrill+https", "mandrill+smtp", "mandrill+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Bridge/Mailgun/Tests/Transport/MailgunTransportFactoryTest.php

@@ -110,7 +110,7 @@ class MailgunTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('mailgun+foo', 'default', self::USER, self::PASSWORD),
-            'The "mailgun+foo" scheme is not supported. Supported schemes for mailer "mailgun" are: "mailgun", "mailgun+api", "mailgun+https", "mailgun+smtp", "mailgun+smtps".',
+            'The "mailgun+foo" scheme is not supported; supported schemes for mailer "mailgun" are: "mailgun", "mailgun+api", "mailgun+https", "mailgun+smtp", "mailgun+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Bridge/Postmark/Tests/Transport/PostmarkTransportFactoryTest.php

@@ -88,7 +88,7 @@ class PostmarkTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('postmark+foo', 'default', self::USER),
-            'The "postmark+foo" scheme is not supported. Supported schemes for mailer "postmark" are: "postmark", "postmark+api", "postmark+smtp", "postmark+smtps".',
+            'The "postmark+foo" scheme is not supported; supported schemes for mailer "postmark" are: "postmark", "postmark+api", "postmark+smtp", "postmark+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Bridge/Sendgrid/Tests/Transport/SendgridTransportFactoryTest.php

@@ -88,7 +88,7 @@ class SendgridTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('sendgrid+foo', 'sendgrid', self::USER),
-            'The "sendgrid+foo" scheme is not supported. Supported schemes for mailer "sendgrid" are: "sendgrid", "sendgrid+api", "sendgrid+smtp", "sendgrid+smtps".',
+            'The "sendgrid+foo" scheme is not supported; supported schemes for mailer "sendgrid" are: "sendgrid", "sendgrid+api", "sendgrid+smtp", "sendgrid+smtps".',
         ];
     }
 

src/Symfony/Component/Mailer/Exception/UnsupportedHostException.php

@@ -1,64 +0,0 @@
-<?php
-
-/*
- * This file is part of the Symfony package.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- *
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
-
-namespace Symfony\Component\Mailer\Exception;
-
-use Symfony\Component\Mailer\Bridge;
-use Symfony\Component\Mailer\Transport\Dsn;
-
-/**
- * @author Konstantin Myakshin <molodchick@gmail.com>
- */
-class UnsupportedHostException extends LogicException
-{
-    private const HOST_TO_PACKAGE_MAP = [
-        'gmail' => [
-            'class' => Bridge\Google\Transport\GmailTransportFactory::class,
-            'package' => 'symfony/google-mailer',
-        ],
-        'mailgun' => [
-            'class' => Bridge\Mailgun\Transport\MailgunTransportFactory::class,
-            'package' => 'symfony/mailgun-mailer',
-        ],
-        'postmark' => [
-            'class' => Bridge\Postmark\Transport\PostmarkTransportFactory::class,
-            'package' => 'symfony/postmark-mailer',
-        ],
-        'sendgrid' => [
-            'class' => Bridge\Sendgrid\Transport\SendgridTransportFactory::class,
-            'package' => 'symfony/sendgrid-mailer',
-        ],
-        'ses' => [
-            'class' => Bridge\Amazon\Transport\SesTransportFactory::class,
-            'package' => 'symfony/amazon-mailer',
-        ],
-        'mandrill' => [
-            'class' => Bridge\Mailchimp\Transport\MandrillTransportFactory::class,
-            'package' => 'symfony/mailchimp-mailer',
-        ],
-    ];
-
-    public function __construct(Dsn $dsn)
-    {
-        $provider = $dsn->getScheme();
-        if (false !== $pos = strpos($provider, '+')) {
-            $provider = substr($provider, 0, $pos);
-        }
-        $package = self::HOST_TO_PACKAGE_MAP[$provider] ?? null;
-        if ($package && !class_exists($package['class'])) {
-            parent::__construct(sprintf('Unable to send emails via "%s" as the bridge is not installed. Try running "composer require %s".', $provider, $package['package']));
-
-            return;
-        }
-
-        parent::__construct(sprintf('The "%s" scheme is not supported.', $dsn->getScheme()));
-    }
-}

src/Symfony/Component/Mailer/Exception/UnsupportedSchemeException.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Mailer\Exception;
 
+use Symfony\Component\Mailer\Bridge;
 use Symfony\Component\Mailer\Transport\Dsn;
 
 /**
@@ -18,8 +19,51 @@ use Symfony\Component\Mailer\Transport\Dsn;
  */
 class UnsupportedSchemeException extends LogicException
 {
-    public function __construct(Dsn $dsn, string $name, array $supported)
+    private const SCHEME_TO_PACKAGE_MAP = [
+        'gmail' => [
+            'class' => Bridge\Google\Transport\GmailTransportFactory::class,
+            'package' => 'symfony/google-mailer',
+        ],
+        'mailgun' => [
+            'class' => Bridge\Mailgun\Transport\MailgunTransportFactory::class,
+            'package' => 'symfony/mailgun-mailer',
+        ],
+        'postmark' => [
+            'class' => Bridge\Postmark\Transport\PostmarkTransportFactory::class,
+            'package' => 'symfony/postmark-mailer',
+        ],
+        'sendgrid' => [
+            'class' => Bridge\Sendgrid\Transport\SendgridTransportFactory::class,
+            'package' => 'symfony/sendgrid-mailer',
+        ],
+        'ses' => [
+            'class' => Bridge\Amazon\Transport\SesTransportFactory::class,
+            'package' => 'symfony/amazon-mailer',
+        ],
+        'mandrill' => [
+            'class' => Bridge\Mailchimp\Transport\MandrillTransportFactory::class,
+            'package' => 'symfony/mailchimp-mailer',
+        ],
+    ];
+
+    public function __construct(Dsn $dsn, string $name = null, array $supported = [])
     {
-        parent::__construct(sprintf('The "%s" scheme is not supported. Supported schemes for mailer "%s" are: "%s".', $dsn->getScheme(), $name, implode('", "', $supported)));
+        $provider = $dsn->getScheme();
+        if (false !== $pos = strpos($provider, '+')) {
+            $provider = substr($provider, 0, $pos);
+        }
+        $package = self::SCHEME_TO_PACKAGE_MAP[$provider] ?? null;
+        if ($package && !class_exists($package['class'])) {
+            parent::__construct(sprintf('Unable to send emails via "%s" as the bridge is not installed; try running "composer require %s".', $provider, $package['package']));
+
+            return;
+        }
+
+        $message = sprintf('The "%s" scheme is not supported', $dsn->getScheme());
+        if ($name && $supported) {
+            $message .= sprintf('; supported schemes for mailer "%s" are: "%s"', $name, implode('", "', $supported));
+        }
+
+        parent::__construct($message.'.');
     }
 }

src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportFactoryTest.php

@@ -44,7 +44,7 @@ class SendmailTransportFactoryTest extends TransportFactoryTestCase
     {
         yield [
             new Dsn('sendmail+http', 'default'),
-            'The "sendmail+http" scheme is not supported. Supported schemes for mailer "sendmail" are: "sendmail", "sendmail+smtp".',
+            'The "sendmail+http" scheme is not supported; supported schemes for mailer "sendmail" are: "sendmail", "sendmail+smtp".',
         ];
     }
 }

src/Symfony/Component/Mailer/Transport.php

@@ -19,7 +19,7 @@ use Symfony\Component\Mailer\Bridge\Mailgun\Transport\MailgunTransportFactory;
 use Symfony\Component\Mailer\Bridge\Postmark\Transport\PostmarkTransportFactory;
 use Symfony\Component\Mailer\Bridge\Sendgrid\Transport\SendgridTransportFactory;
 use Symfony\Component\Mailer\Exception\InvalidArgumentException;
-use Symfony\Component\Mailer\Exception\UnsupportedHostException;
+use Symfony\Component\Mailer\Exception\UnsupportedSchemeException;
 use Symfony\Component\Mailer\Transport\Dsn;
 use Symfony\Component\Mailer\Transport\FailoverTransport;
 use Symfony\Component\Mailer\Transport\NullTransportFactory;
@@ -146,7 +146,7 @@ class Transport
             }
         }
 
-        throw new UnsupportedHostException($dsn);
+        throw new UnsupportedSchemeException($dsn);
     }
 
     private static function getDefaultFactories(EventDispatcherInterface $dispatcher = null, HttpClientInterface $client = null, LoggerInterface $logger = null): iterable